Add token name to structure #1336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ivshti
reviewed
Feb 26, 2025
| @@ -42,7 +44,7 @@ contract BalanceGetter is Simulation { | |||
| TokenInfo[] memory results = new TokenInfo[](len); | |||
| for (uint256 i = 0; i < len; i++) { | |||
| if (tokenAddrs[i] == address(0)) { | |||
| results[i] = TokenInfo('ETH', address(account).balance, 18, bytes('')); | |||
| results[i] = TokenInfo('ETH', 'Ether', address(account).balance, 18, bytes('')); | |||
There was a problem hiding this comment.
not directly related to the PR, but how do we handle this for non-eth networks? as far as I remember we change the hardcoded value somewhere in the portfolio library in common
There was a problem hiding this comment.
good catch, it should have been done here it is already done here https://github.com/AmbireTech/ambire-common/blob/v2/src/libs/portfolio/getOnchainBalances.ts#L214
jordan-enev
reviewed
Feb 27, 2025
| uint256 tokenId = INonfungiblePositionManager(positionManagementAddr).tokenOfOwnerByIndex(userAddr, i); | ||
| Position memory positionInfo = INonfungiblePositionManager(positionManagementAddr).positions(tokenId); | ||
|
|
||
| if(positionInfo.liquidity == 0) continue; |
jordan-enev
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://github.com/AmbireTech/ambire-app/issues/3951
adds token name property to: