Fix / Sign Message - Overwrite bug #1338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al message string with a hex value, resulting in a non-human-readable message when signing fails. Change: Simplified `PlainTextMessage.message` to accept only `string` values. Change: Improved TypeScript parameter definitions for `verifyMessage` by making the main properties required. Enforced a strict requirement that either `message` or `typedData` must be provided, but not both. Remove: Removed `finalDigest` as it was unused in the code. Refactored `verifyMessage` to ensure it only accepts either `message` or `typedData`, never both.
|
Update: It's not used in Relayer. Relayer uses https://github.com/AmbireTech/signature-validator/, so we are safe to drop support to I couldn't find any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/AmbireTech/ambire-app/issues/3263.
PlainTextMessage.messageto accept onlystringvalues.verifyMessageby making the main properties required. Enforced a strict requirement that eithermessageortypedDatamust be provided, but not both.finalDigestparameter as it was never passed toverifyMessage. RefactoredverifyMessageto ensure it only accepts eithermessageortypedData, never both.