Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display internal errors against custom resource status fields #144

Open
AmitKumarDas opened this issue May 23, 2020 · 1 comment
Open

Comments

@AmitKumarDas
Copy link
Owner

ProblemStatement: As a DevOps engineer, I want metac to display internal errors such as RBAC failure, discovery failure, & other runtime errors that happens during reconciliation against the custom resource that was being reconciled. As of now, I have no idea if something has gone wrong unless I check the logs of metac.

Refer:

@AmitKumarDas
Copy link
Owner Author

AmitKumarDas commented May 23, 2020

There has been several discussions to expose these errors as events & metrics. However, metac should first make this error available in a way that provides immediate help. Events & metrics will be designed & implemented eventually.

Metac can log these runtime errors against a specific field of custom resource e.g. status.metac.error
In addition, this should be enabled only when the sync hook response api desires such a behaviour via a boolean field.

e.g. https://github.com/AmitKumarDas/metac/blob/master/controller/generic/hooks.go#L49

type SyncHookResponse struct {

        ....

        // this is the new boolean flag
        // if true metac will set the custom resource's status.metac.error 
        // with latest runtime error
        LogRuntimeError  bool `json:"logRuntimeError"`
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant