-
Notifications
You must be signed in to change notification settings - Fork 2
/
Copy pathtest_validation.py
236 lines (192 loc) · 8.38 KB
/
test_validation.py
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
from unittest.mock import Mock
import pytest
from great_expectations.checkpoint import (
MicrosoftTeamsNotificationAction,
SlackNotificationAction,
)
from great_expectations.expectations import ExpectColumnDistinctValuesToEqualSet
from pyspark.sql import SparkSession
from src.dq_suite.common import Rule, ValidationSettings
from src.dq_suite.validation import ValidationRunner
@pytest.fixture
def validation_settings_obj():
spark_session_mock = Mock(spec=SparkSession)
validation_settings_obj = ValidationSettings(
spark_session=spark_session_mock,
catalog_name="the_catalog",
table_name="the_table",
validation_name="the_validation",
)
return validation_settings_obj
@pytest.fixture
def validation_runner_obj(validation_settings_obj):
return ValidationRunner(validation_settings_obj=validation_settings_obj)
@pytest.mark.usefixtures("validation_settings_obj")
@pytest.mark.usefixtures("validation_runner_obj")
class TestValidationRunner:
"""
Note: the following methods are not yet tested, because they consist
entirely of (a sequence of calls to) GX methods/functions:
- create_batch_definition
- create_validation_definition
- _get_or_add_checkpoint
- run
"""
def test_initialisation_with_none_valued_validation_settings_raises_value_error(
self,
):
with pytest.raises(ValueError):
assert ValidationRunner(validation_settings_obj=None)
def test_initialisation_with_wrong_typed_validation_settings_raises_value_error(
self,
):
with pytest.raises(ValueError):
assert ValidationRunner(validation_settings_obj=123)
def test_initialisation_works_as_expected(self, validation_settings_obj):
validation_runner_obj = ValidationRunner(
validation_settings_obj=validation_settings_obj
)
# After setting all attribute values, a data_context should be created
assert validation_runner_obj.data_context is not None
def test_get_or_add_expectation_suite_works_as_expected(
self, validation_runner_obj
):
# Initially, no suites exist in the data context
suites_list = list(validation_runner_obj.data_context.suites.all())
assert len(suites_list) == 0
# Create a new validation suite
expected_expectation_suite_name = (
"previously_undefined_validation_suite"
)
validation_runner_obj.expectation_suite_name = (
expected_expectation_suite_name
)
first_suite = validation_runner_obj._get_or_add_expectation_suite()
# Now, there should be 1 suite in the data context
suites_list = list(validation_runner_obj.data_context.suites.all())
assert len(suites_list) == 1
assert suites_list[0] == first_suite
# Calling the function again should return the existing validation suite
second_suite = validation_runner_obj._get_or_add_expectation_suite()
suites_list = list(validation_runner_obj.data_context.suites.all())
assert len(suites_list) == 1
assert suites_list[0] == first_suite
assert first_suite == second_suite
def test_get_nonexistent_gx_expectation_object_raises_attribute_error(
self, validation_runner_obj
):
with pytest.raises(AttributeError):
the_rule = Rule(
rule_name="NonExistentExpectation",
parameters={"column": "the_column", "value_set": [1, 2, 3]},
)
validation_runner_obj._get_gx_expectation_object(
validation_rule=the_rule, table_name="the_table"
)
def test_get_gx_expectation_object(self, validation_runner_obj):
the_rule = Rule(
rule_name="ExpectColumnDistinctValuesToEqualSet",
parameters={"column": "the_column", "value_set": [1, 2, 3]},
)
the_expectation_object = (
validation_runner_obj._get_gx_expectation_object(
validation_rule=the_rule, table_name="the_table"
)
)
assert isinstance(
the_expectation_object, ExpectColumnDistinctValuesToEqualSet
)
assert the_expectation_object.column == the_rule["parameters"]["column"]
assert (
the_expectation_object.value_set
== the_rule["parameters"]["value_set"]
)
def test_add_expectations_to_suite_works_as_expected(
self, validation_runner_obj
):
validation_rules_list = [
Rule(
rule_name="ExpectColumnDistinctValuesToEqualSet",
parameters={"column": "the_column", "value_set": [1, 2, 3]},
)
]
validation_runner_obj.add_expectations_to_suite(
validation_rules_list=validation_rules_list
)
suites_list = list(validation_runner_obj.data_context.suites.all())
expectations_list = suites_list[0]["expectations"]
assert len(expectations_list) == 1
assert isinstance(
expectations_list[0], ExpectColumnDistinctValuesToEqualSet
)
def test_create_batch_definition(self, validation_runner_obj):
# Initially, no batch definitions exist in the data context
# validation_runner_obj.create_batch_definition()
# TODO: mock use of spark for
# data_context.data_sources.add_or_update_spark
pass
def test_create_validation_definition(self, validation_runner_obj):
# TODO: mock use of batch_definition for ValidationDefinition
pass
def test_create_action_list_with_slack_webhook(self, validation_runner_obj):
# Initially, there are no actions in the action_list parameter
assert validation_runner_obj.action_list is None
validation_runner_obj.slack_webhook = "the_slack_webhook"
validation_runner_obj._create_action_list()
# Now there should be 1 SlackNotificationAction in the action_list
assert isinstance(validation_runner_obj.action_list, list)
assert len(validation_runner_obj.action_list) == 1
assert isinstance(
validation_runner_obj.action_list[0], SlackNotificationAction
)
def test_create_action_list_without_slack_webhook(
self, validation_runner_obj
):
# Initially, there are no actions in the action_list parameter
assert validation_runner_obj.action_list is None
validation_runner_obj.slack_webhook = None
validation_runner_obj._create_action_list()
# Now there should still be no actions in the action_list parameter
assert isinstance(validation_runner_obj.action_list, list)
assert len(validation_runner_obj.action_list) == 0
def test_create_action_list_with_ms_teams_webhook(
self, validation_runner_obj
):
# Initially, there are no actions in the action_list parameter
assert validation_runner_obj.action_list is None
validation_runner_obj.ms_teams_webhook = "the_ms_teams_webhook"
validation_runner_obj._create_action_list()
# Now there should be 1 MicrosoftTeamsNotificationAction in the action_list
assert isinstance(validation_runner_obj.action_list, list)
assert len(validation_runner_obj.action_list) == 1
assert isinstance(
validation_runner_obj.action_list[0],
MicrosoftTeamsNotificationAction,
)
def test_create_action_list_without_ms_teams_webhook(
self, validation_runner_obj
):
# Initially, there are no actions in the action_list parameter
assert validation_runner_obj.action_list is None
validation_runner_obj.ms_teams_webhook = None
validation_runner_obj._create_action_list()
# Now there should still be no actions in the action_list parameter
assert isinstance(validation_runner_obj.action_list, list)
assert len(validation_runner_obj.action_list) == 0
def test_get_or_add_checkpoint(self, validation_runner_obj):
# TODO: mock use of ValidationDefinition for Checkpoint
pass
class TestValidate:
"""
Note: this function is not yet tested, because it consists entirely of
(a sequence of calls to) GX methods/functions.
"""
def test_validate(self):
pass
class TestRun:
"""
Note: this function is not yet tested, because it consists entirely of
(a sequence of calls to) GX methods/functions.
"""
def test_run(self):
pass