Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF Tools breaks other extensions in a weird way #264

Open
PEZ opened this issue Dec 21, 2023 · 1 comment
Open

glTF Tools breaks other extensions in a weird way #264

PEZ opened this issue Dec 21, 2023 · 1 comment

Comments

@PEZ
Copy link

PEZ commented Dec 21, 2023

Hello, thanks for providing glTF Tools!

It was brought to my attention that the extension broke Calva, a Clojure extension. I have now removed the code in Calva that was affected, but created a somewhat minimal reproduction extension here:

I put the steps to reproduce in the README of that project. It is about running that extension and watching it break when the glTF extension is activated. The way it breaks is a bit crazy, and beyond what I can even start to understand, but maybe you as the authors of glTF tools can understand it?

@emackey
Copy link
Member

emackey commented Aug 1, 2024

I've really no idea what's going on here. "Call stack exceeded" sounds like something called itself in an infinite recursion, but I don't see how the two extensions being activated at the same time could cause such a thing. Maybe there's some incompatibility between different versions of NodeJS's Buffer object in play here, as both extensions make use of that. The next version of gltf-tools will include an updated version, perhaps that will change this somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants