-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] eslint-plugin-perfectionist
#194
Comments
Well, there are a lot of pros and lot of cons. PROS
CONS
I wouldn't even list this as a PRO, to be honest, these sort of perf optimizations are usually negligible in the real world. Also has to be said that ESLint has a core rule for object keys ordering. But it doesn't even autofix, so it's pretty bad. |
Yep.
True enough, but they're getting deprecated in favor of perfectionist.
Yeah, that's probably worth considering.
Yeah. I don't think it makes a real difference, but it's not a negative. |
Where did you see this? |
https://typescript-eslint.io/rules/sort-type-constituents/, and I thought there was some discussion in the eslint org with the stylistic migration, though a quick search doesn't pop it up. |
Sorts stuff-keeping stuff consistent is nice, but it also helps performance (very slightly), as objects in a different order aren't optimized by the JIT, and I don't believe any bundlers sort keys, though I'd be happy to be proven wrong.
It could also replace
eslint-simple-import-sort
.Link: https://perfectionist.dev/
I know I can add it manually, but I'd prefer to see if @AndreaPontrandolfo supports the idea, as putting it in sheriff helps provide a better experience for all.
I'd be willing to PR this, likely next week.
The text was updated successfully, but these errors were encountered: