Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle sheriff-types #233

Open
lishaduck opened this issue Aug 24, 2024 · 1 comment
Open

Bundle sheriff-types #233

lishaduck opened this issue Aug 24, 2024 · 1 comment
Assignees
@AndreaPontrandolfo
Labels
accepted The issue is accepted and a PR can be proposed. refactor

Comments

@lishaduck
Copy link
Contributor

@lishaduck you know, i'm thinking an even better thing we could do to simplify stuff.
Just like with constants, we shouldn't ship the @sherifforg/types as a separate package. We can just re-export it from eslint-config-sheriff.
I don't see any downsides to it, only upsides, now that i think about it.

Originally posted by @AndreaPontrandolfo in #229 (comment)
@lishaduck lishaduck changed the title @lishaduck you know, i'm thinking an even better thing we could do to simplify stuff. Bundle sheriff-types Aug 24, 2024
@lishaduck lishaduck mentioned this issue Aug 24, 2024
Open
@AndreaPontrandolfo AndreaPontrandolfo added refactor accepted The issue is accepted and a PR can be proposed. labels Aug 25, 2024
@AndreaPontrandolfo AndreaPontrandolfo self-assigned this Aug 25, 2024
@lishaduck
Copy link
Contributor Author

lishaduck commented Aug 25, 2024 •
edited
Loading

~Blocked on #229

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreaPontrandolfo AndreaPontrandolfo

Labels
accepted The issue is accepted and a PR can be proposed. refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndreaPontrandolfo @lishaduck