Skip to content

Published jar not up-to-date with source on github #2

Description

@rm-hull

published 1.0.0-SNAPSHOT in clojars has:

(defn with-etag
  "Generates an etag header for a response body according to etag-generator and transforms response according to response-fn."
  [handler {:keys [response-fn]
            :or {response-fn (cached-response (create-hashed-etag-fn md5))}}]
  (fn [request]
    (let [old-etag (get-in request [:headers "if-none-match"])
          response (handler request)]
      (response-fn old-etag response))))

whereas github sources:

(defn with-etag
  "Generates an etag header for a response body according to etag-generator and transforms response according to response-fn."
  [handler {:keys [etag-generator response-fn]
            :or {etag-generator create-uid
                 response-fn cached-response}}]
  (fn [request]
    (let [old-etag (get-in request [:headers "if-none-match"])
          response (handler request)
          new-etag (etag-generator response)]
      (response-fn old-etag new-etag response))))

This caused quite a bit of confusion as I was looking at the source and getting behaviour at runtime.

Could you publish a new version to clojars please?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions