Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Rolls and Fumbles #325

Open
pedroaugustobt opened this issue Sep 25, 2023 · 8 comments
Open

Critical Rolls and Fumbles #325

pedroaugustobt opened this issue Sep 25, 2023 · 8 comments

Comments

@pedroaugustobt
Copy link

In an earlier AM build of the system, when a roll was a Critical or a Fumble, you had to click the green / red bar to get it to then roll - this seemed to give the system time to then roll the die using the Dice so Nice / Dice tray, which my group loved happen on the board- especially when the Dice 'exploded' into a BIG crit!

Also, when they'd seen that they fumbled, they had to click to roll the next Dice to determine the fumble total. At this point, most of my group would apply Luck to offset the next scary roll.

The auto rolling of Crits and Fumbles, whilst keeping the game running more quickly, took that option away, so we just house rule it by ignoring the auto-roll player fumbles and allowing them to apply luck and roll a new D10 to determine it, and then accepting that roll.

I'm taking a few look at the codes and I understand that when the die explodes, it throws the printed result directly into the chat, without rolling the exploded die or the previous one.

@ortegamarcel
Copy link

ortegamarcel commented Sep 25, 2023

I already tried it once to fix that. The problem is the way the roll logic is implemented, so that it is not really compatible with Dice so Nice. Instead it would be necessary to completely rewrite the function. That would be possible, but it could lead to some unexpected behaviour on other places, that's why I for now only included it in the Token Action HUD TheWitcherTRPG - Module. There you have the option in the settings to use the "new" dice-rolling-logic. That will also show a animation on crits/fumbles. But they are fully automated.

@pedroaugustobt
Copy link
Author

pedroaugustobt commented Sep 25, 2023

I already tried it once to fix that. The problem is the way the roll logic is implemented, so that it is not really compatible with Dice so Nice. Instead it would be necessary to completely rewrite the function. That would be possible, but it could lead to some unexpected behaviour on other places, that's why I for now only included it in the Token Action HUD TheWitcherTRPG - Module. There you have the option in the settings to use the "new" dice-rolling-logic. That will also show a animation on crits/fumbles. But they are fully automated.

How do i configure this new dice-rolling-logic? Not working for me...

I downloaded your latest version

@ortegamarcel
Copy link

ortegamarcel commented Sep 26, 2023

foundry_token-action-hud-setting

Go to settings and uncheck the box on "Roll Skills Natively". This should be the default if you are using TheWitcherTRPG v0.96.

@pedroaugustobt
Copy link
Author

image
Does this work in 0.97? I unchecked the option and it's not working, it doesn't roll the dice and prints in the chat instantly, I couldn't find any error log in the console.

@ortegamarcel
Copy link

ortegamarcel commented Sep 26, 2023

Looks like 0.97 is not compatible with Foundry v10. Either downgrade the systems version to 0.96 or update Foundry to v11.

BTW: When you have more problems with Token Action HUD please report them here.

@AnthonyMonette
Copy link
Owner

One thing that could be possible is to add a flag in the system setting to automatically roll crit/fumble and when this option is checked-out it goes back to the previous behavior where user would need to click on the button to roll the crit/fumble. What do you think?

@pedroaugustobt
Copy link
Author

One thing that could be possible is to add a flag in the system setting to automatically roll crit/fumble and when this option is checked-out it goes back to the previous behavior where user would need to click on the button to roll the crit/fumble. What do you think?

Yeah, its a solution, but when you craft an item with a high DC and player rolls 10 and still doesn't pass, the item will not be crafted.

Currently i deleted a line of code where it calculates the previous value taken on the dice + the current value of the explosion, this briefly resolved It, but the dice that appears in the chatMessage os the total of the firts dice rolled.

@pedroaugustobt
Copy link
Author

The error is in the part where it prints the summed result, it behaves by rolling the dice under the table, thus cutting the Dice so Nice animation and printing the result in the chatMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants