Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests to make sure internal_transfers properly detect DELEGATECALLS #2

Open
2 tasks
BlinkyStitt opened this issue Apr 6, 2022 · 0 comments
Open
2 tasks

Comments

@BlinkyStitt
Copy link

Elevator pitch:

DELEGATECALL makes parsing traces even more complicated than just parsing CALLS. We need thorough tests.

Value:

Accurate parsing of traces is important.

Design approach:

https://knowyourmeme.com/memes/pepe-silvia

Task list:

Estimated completion date:

...

Design review:

Do not signoff unless:

    1. agreed the tasks and design approach will achieve acceptance, and
    1. the work can be completed by one person within the SLA.
      Design reviewers should consider simpler approaches to achieve goals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant