Update to .NET 9 SDK (#2003)

- Build with the .NET 9 SDK.
- Add tests TFM for `net9.0`.
- Remove tests for `net6.0` TFM.
- Run workflows on PRs to `dotnet-vnext` branch.
- Only audit direct NuGet dependencies.
- Fix IDE0022 warning.
- Temporarily disable some tests that are failing in GitHub Actions.
- Add usage of `[DebuggerDisableUserUnhandledExceptions]` to avoid newer versions of the Visual Studio debugger for breaking for exceptions on async code paths we are intentionally handling.
- Bump version to 8.5.0.

Author: martincostello

.github/workflows/actions-lint.yml

@@ -2,13 +2,18 @@ name: actions-lint
 
 on:
   push:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
     paths-ignore:
       - '**/*.gitattributes'
       - '**/*.gitignore'
       - '**/*.md'
   pull_request:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
+      - dotnet-vnext
   workflow_dispatch:
 
 permissions:

.github/workflows/build.yml

@@ -2,10 +2,15 @@ name: build
 
 on:
   push:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
     tags: [ '*' ]
   pull_request:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
+      - dotnet-vnext
   workflow_dispatch:
 
 env:

.github/workflows/dependency-review.yml

@@ -2,7 +2,10 @@ name: dependency-review
 
 on:
   pull_request:
-    branches: [ main, release/* ]
+    branches: 
+      - main
+      - release/*
+      - dotnet-vnext
 
 permissions:
   contents: read

.github/workflows/gh-pages.yml

@@ -2,9 +2,14 @@ name: github-pages
 
 on:
   push:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
   pull_request:
-    branches: [ main, release/* ]
+    branches:
+      - main
+      - release/*
+      - dotnet-vnext
   workflow_dispatch:
 
 permissions:
@@ -14,6 +19,7 @@ jobs:
 
   build-docs:
     runs-on: ubuntu-latest
+    timeout-minutes: 20
 
     steps:
 
@@ -37,6 +43,8 @@ jobs:
       uses: actions/setup-dotnet@3e891b0cb619bf60e2c25674b222b8940e2c1c25 # v4.1.0
 
     - name: Generate documentation
+      env:
+        DOTNET_ROLL_FORWARD: LatestMajor
       run: |
         dotnet tool restore
         dotnet build --configuration Release /p:SKIP_POLLY_ANALYZERS=true

.github/workflows/on-push-do-docs.yml

@@ -2,7 +2,7 @@ name: on-push-do-docs
 
 on:
   push:
-    branches: [main]
+    branches: [ main ]
     paths: [ "src/Snippets/**" ]
   workflow_dispatch:
 

.github/workflows/updater-approve.yml

@@ -2,7 +2,10 @@ name: updater-approve
 
 on:
   pull_request:
-    branches: [ main, release/* ]
+    branches: 
+      - main
+      - release/*
+      - dotnet-vnext
 
 permissions:
   contents: read

Directory.Packages.props

@@ -4,6 +4,10 @@
     <PollyVersion>8.4.2</PollyVersion>
     <MicrosoftExtensionsVersion>8.0.0</MicrosoftExtensionsVersion>
   </PropertyGroup>
+  <PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'net9.0'))">
+    <MicrosoftExtensionsVersion>9.0.0</MicrosoftExtensionsVersion>
+    <MicrosoftExtensionsTimeProviderVersion>9.0.0</MicrosoftExtensionsTimeProviderVersion>
+  </PropertyGroup>
   <ItemGroup>
     <PackageVersion Include="coverlet.msbuild" Version="6.0.2" />
     <PackageVersion Include="BenchmarkDotNet" Version="0.14.0" />
@@ -41,6 +45,7 @@
     <PackageVersion Include="System.Diagnostics.DiagnosticSource" Version="$(MicrosoftExtensionsVersion)" />
     <PackageVersion Include="System.Threading.RateLimiting" Version="$(MicrosoftExtensionsVersion)" />
     <PackageVersion Include="System.Threading.Tasks.Extensions" Version="4.5.4" />
+    <PackageVersion Include="System.Text.Json" Version="9.0.0" />
     <PackageVersion Include="System.ValueTuple" Version="4.5.0" />
     <PackageVersion Include="xunit" Version="2.9.2" />
     <PackageVersion Include="xunit.runner.visualstudio" Version="2.8.2" />

bench/Polly.Benchmarks/Polly.Benchmarks.csproj

@@ -2,7 +2,7 @@
   <PropertyGroup>
     <IsPackable>false</IsPackable>
     <OutputType>Exe</OutputType>
-    <TargetFrameworks>net6.0;net8.0</TargetFrameworks>
+    <TargetFrameworks>net8.0;net9.0</TargetFrameworks>
     <Nullable>enable</Nullable>
     <ProjectType>Benchmark</ProjectType>
     <NoWarn>$(NoWarn);CA1822;IDE0060</NoWarn>

bench/Polly.Core.Benchmarks/Polly.Core.Benchmarks.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFrameworks>net9.0;net8.0</TargetFrameworks>
     <RootNamespace>Polly</RootNamespace>
     <ImplicitUsings>true</ImplicitUsings>
     <ProjectType>Benchmark</ProjectType>

bench/benchmarks.ps1

@@ -20,6 +20,6 @@ if ($Interactive -ne $true) {
 
 $project = Join-Path "Polly.Core.Benchmarks" "Polly.Core.Benchmarks.csproj"
 
-dotnet run --configuration $Configuration --framework net8.0 --project $project $additionalArgs
+dotnet run --configuration $Configuration --framework net9.0 --project $project $additionalArgs
 
 exit $LASTEXITCODE