This repository was archived by the owner on Jan 26, 2026. It is now read-only.
Fix CI failures: Update Ubuntu 24.04 package names and resolve clippy errors#2
Merged
Fix CI failures: Update Ubuntu 24.04 package names and resolve clippy errors#2
Conversation
…sues - Update GTK/WebKit package names for Ubuntu 24.04 compatibility - Replace libwebkit2gtk-4.0-dev with libwebkit2gtk-4.1-dev - Replace libjavascriptcoregtk-4.0-dev with libjavascriptcoregtk-4.1-dev - Fix Cargo.toml edition from invalid "2024" to "2021" - Fix clippy warnings to prevent CI failures: - Mark FFI functions as unsafe - Fix redundant closures - Fix single match patterns - Prefix unused variables and fields with underscore - Fix non-canonical PartialOrd implementation - Apply cargo fmt to fix formatting issues Co-authored-by: Ru1vly <67930426+Ru1vly@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI workflows to ensure successful task completion
Fix CI failures: Update Ubuntu 24.04 package names and resolve clippy errors
Nov 12, 2025
rvoidex7
pushed a commit
to rvoidex7/ahenk
that referenced
this pull request
Nov 19, 2025
This PR completes the transformation of FocusSuite into Ahenk, a focused P2P sync engine. All application-specific features have been removed and clearly documented as out-of-scope. **🧹 Major Cleanup (PR #1: Broken tauri_api.rs)** - Removed ALL Task, Habit, Pomodoro, Block, Soundscape management from tauri_api.rs - Reduced file from 628 lines to 149 lines (76% reduction) - Only User Management and P2P Sync commands remain - Fixed all compile errors from deleted logic functions - Updated function names: nexus_* → ahenk_* **📚 Documentation Overhaul (PR Appaholics#2: Documentation Cleanup)** - CHANGELOG.md: Removed all false feature claims, now accurately reflects core infrastructure - CORE_API_VERIFICATION_REPORT.md: Deprecated and archived (outdated Task/Habit claims) - NEW: ARCHITECTURE.md - Clear, honest documentation of what Ahenk IS and IS NOT - Explicit guidance for app developers on using Ahenk as sync backend **🗄️ Database Schema Alignment (PR Appaholics#3: Schema Consistency)** - schema.sql: Now matches migration/001_initial_schema.sql exactly - Removed all Task, Habit, Pomodoro, Block-related tables - Only 4 core tables: users, devices, oplog, peers - Added clear developer notes on extending schema **✅ What Ahenk Now Provides** - User authentication (register/login with Argon2) - Multi-device management - P2P networking (libp2p, mDNS, Relay, DCUtR) - CRDT sync (OpLog, HLC timestamps, conflict resolution) - Cross-platform FFI (iOS, Android, Desktop) **❌ What Ahenk Does NOT Provide** - Task management - Habit tracking - Pomodoro timers - Time blocking - Soundscapes - ANY application-specific UI or business logic **🎯 Identity Clarification** Ahenk is now clearly positioned as: - "P2P Database Synchronization Engine" - NOT "A productivity app with sync" - Infrastructure library for apps to build upon **🔧 Technical Changes** - tauri_api.rs: 628 → 149 lines - CHANGELOG.md: Completely rewritten for accuracy - schema.sql: Aligned with active migrations - ARCHITECTURE.md: New comprehensive guide **📊 Test Results** - 17/18 tests passing - 1 P2P network test fails (expected in CI environment) - Build successful - All critical functionality verified **🚀 Migration Path for Existing Users** Applications using old FocusSuite code should: 1. Extract domain models to application layer 2. Use Ahenk only for User + Device + Sync 3. Create custom tables alongside Ahenk core tables 4. Use build_oplog_entry() for syncing custom data This is now a production-ready, focused, and honest sync infrastructure. Addresses feedback from independent code review identifying "identity crisis" between being a sync engine vs. complete application.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All CI jobs were failing due to deprecated package names for Ubuntu 24.04 and code quality issues caught by clippy's
-D warningsflag.Package Dependencies
libwebkit2gtk-4.0-dev→libwebkit2gtk-4.1-devlibjavascriptcoregtk-4.0-dev→libjavascriptcoregtk-4.1-devCargo.toml:"2024"→"2021"Code Quality Fixes
unsafePartialOrdto delegate toOrd::cmp|e| fn(e)→fn)cargo fmtfor import orderingOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.