Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple vcpkg platform toolsets (v141 & v142) & explicit VSCode generator #306

Open
mraduldubey opened this issue Sep 12, 2023 · 0 comments

Comments

@mraduldubey
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

  1. On Windows, we support Visual Studio 2017 & Visual Studio 2019. Both are different toolsets.
  2. More importantly, Aprapipes pipeline does not support VCPKG_PLATFORM_TOOLSET v143. So, in case the users have an existing vcpkg setup (say, with VCPKG_PLATFORM_TOOLSET v143), the Aprapipes setup fails.
  3. The build_windows*.bat scripts do not explicity mention the generators (-G option), which results in auto selection of the Visual Studio version.

Describe the solution you'd like

  1. We should explicitly support VCPKG_PLATFORM_TOOLSET v141 and v142.
  2. We should explicitly set generator option in our build scripts.

Describe alternatives you've considered

Additional context
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant