Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added processEOS and resolved issue #335 with unit test #336

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added processEOS and resolved issue #335 with unit test #336

wants to merge 2 commits into from

Conversation

kushaljain-apra
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #335

Description

Added processEOS for AudioToTextXForm module, implemented a handleflushbuffer function to clear the buffer and send an EOS frame when the buffer size is less than set buffer_size, added a unit test to check handleflushbuffer

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: Bug fix

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@kushaljain-apra kushaljain-apra linked an issue Mar 1, 2024 that may be closed by this pull request
buffer not being flushed when the input buffer size is less than set buffer_size in AudioToTextXForm Module #335
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 13s ⏱️ -1s
309 tests +1  228 ✅ +1  81 💤 ±0  0 ❌ ±0 
228 runs  +1  147 ✅ +1  81 💤 ±0  0 ❌ ±0 

Results for commit 4a29bf9. ± Comparison against base commit 53157e2.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
audioToTextXform_test ‑ checkEOS_asr

audioToTextXform_test ‑ check_eos_frame_asr
audioToTextXform_test ‑ check_flushed_buffer_asr

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Test Results Win-nocuda

  1 files  ±0    1 suites  ±0   10m 27s ⏱️ +6s
304 tests +1  228 ✅ +1  76 💤 ±0  0 ❌ ±0 
228 runs  +1  152 ✅ +1  76 💤 ±0  0 ❌ ±0 

Results for commit 4a29bf9. ± Comparison against base commit 53157e2.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
audioToTextXform_test ‑ checkEOS_asr

audioToTextXform_test ‑ check_eos_frame_asr
audioToTextXform_test ‑ check_flushed_buffer_asr

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Test Results Linux-CudaT

  1 files  ±0    1 suites  ±0   10m 34s ⏱️ +5s
409 tests +1  242 ✅ +1  167 💤 ±0  0 ❌ ±0 
242 runs  +1   75 ✅ +1  167 💤 ±0  0 ❌ ±0 

Results for commit 4ab2e39. ± Comparison against base commit 5358310.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
audioToTextXform_test ‑ checkEOS_asr

audioToTextXform_test ‑ check_eos_frame_asr
audioToTextXform_test ‑ check_flushed_buffer_asr

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Test Results Linux_ARM64

  1 files  ±0    1 suites  ±0   10m 57s ⏱️ +4s
431 tests +1  267 ✅ +1  164 💤 ±0  0 ❌ ±0 
267 runs  +1  103 ✅ +1  164 💤 ±0  0 ❌ ±0 

Results for commit 4ab2e39. ± Comparison against base commit 5358310.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
audioToTextXform_test ‑ checkEOS_asr

audioToTextXform_test ‑ check_eos_frame_asr
audioToTextXform_test ‑ check_flushed_buffer_asr

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024 •
edited
Loading

Test Results Windows-cuda

  1 files  ±0    1 suites  ±0   12m 20s ⏱️ +2s
405 tests +1  289 ✅ +1  116 💤 ±0  0 ❌ ±0 
289 runs  +1  173 ✅ +1  116 💤 ±0  0 ❌ ±0 

Results for commit 4a29bf9. ± Comparison against base commit 53157e2.

This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both. 
audioToTextXform_test ‑ checkEOS_asr

audioToTextXform_test ‑ check_eos_frame_asr
audioToTextXform_test ‑ check_flushed_buffer_asr

♻️ This comment has been updated with latest results.

joiskash
joiskash approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@joiskash joiskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@joiskash joiskash enabled auto-merge (squash) July 16, 2024 07:01
@joiskash
Merge branch 'main' into 335-buffer-not-being-flushed-when-the-input-…
4a29bf9 
…buffer-size-is-less-than-set-buffer_size-in-audiototextxform-module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joiskash joiskash joiskash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

buffer not being flushed when the input buffer size is less than set buffer_size in AudioToTextXForm Module
2 participants
@kushaljain-apra @joiskash