Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mp4Reader FPS should be updated when a new video is opened (parseFS mode only) #356

Open
mohammedzakikochargi opened this issue May 22, 2024 · 0 comments

Comments

@mohammedzakikochargi
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
In the ApraNVR branch, Changes have been added to every update mp4reader's fps based on every new video's fps. Run Mp4Reader tests.

Expected behavior
We need to update the set props in mp4reader to ignore new props where only fps has changed and return or according to me the best way is to have functionality to update the fps at framework level, Since currently the only way to change the fps is using setProps which I think is just a hack or workaround.
Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. chrome, safari]
  • Cuda Version [e.g. 22]
  • Architecture [e.g. x86_64, arm64]

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@mraduldubey mraduldubey changed the title Improve the set props in Mp4Reader's detail when only video's fps changes Mp4Reader FPS should be updated when a new video is opened (parseFS mode only) May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant