Skip to content

Multivariate_Data_preparation Function seems incorrect #3

@saravanan-natarajan

Description

@saravanan-natarajan

Thanks for this awesome repo, great learning
In Custom_ts_multi_data_prep function
X takes out indices (0, 47+1) and y takes indices (49, 59), rather y should take values from (48, 58)
range (0, 48) means it takes 0-47 indices since 48 is exclusive.

indicey = range(i+1, i+1+ horizon)

Is it supposed to be ???

indicey = range(i, i+horizon)

Using this improves R2 as welll. Correct me if am wrong ??

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions