Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in multivariate timeseries data set generation function in your book hands on time series analysis chapter 7 #5

Open
manishhnnegi opened this issue Dec 23, 2022 · 0 comments

Comments

@manishhnnegi
Copy link

In Custom_ts_multi_data_prep function for multivatrate time series analysis in chapter 7 need correction in every chapter discussed in that chapter.
X takes out indices (0, 47+1) and y takes indices (49, 59), rather y should take values from (48, 58)
range (0, 48) means it takes 0-47 indices since 48 is exclusive.

indicey = range(i+1, i+1+ horizon)

it is supposed to be

indicey = range(i, i+horizon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant