Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create conan packages for different versions of Python #55

Open
gagelarsen opened this issue Dec 2, 2020 · 1 comment
Open

Create conan packages for different versions of Python #55

gagelarsen opened this issue Dec 2, 2020 · 1 comment
Assignees
Labels
feature request A new feature for the library.

Comments

@gagelarsen
Copy link
Member

gagelarsen commented Dec 2, 2020

Feature Request: Currently we only build for Python version 3.6.8. We should expand that to work with version 3.7, 3.8 and 3.9, as well as make it easier to expand that when different version of python are released.

Expected Work:

  1. Change pybind option to be a string instead of a bool. Probably something like (None, 3.6.8, 3.7, 3.8, 3.9)
  2. Create new conan dockers for the build process for linux builds.
  3. Update the CMakeLists.txt to be more consistant and use the new pybind string option.
  4. Update build.py to filter out any builds we don't want from the side effect of adding the new versions of python.
  5. Update the upload_python_package function in the conanfile to let aquapi know which version of python this is for.

Things that Came up...

  • Ubuntu no longer supports GCC5 so we dropped support and added GCC8.
@gagelarsen gagelarsen added the feature request A new feature for the library. label Dec 2, 2020
@gagelarsen
Copy link
Member Author

After researching making the new dockers, i found that the latest ubuntu doesn't play well with GCC5. We decided since it wasn't widely used anyways we would drop support for GCC5. We also decided to add support for GCC8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A new feature for the library.
Projects
None yet
Development

No branches or pull requests

3 participants