Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark PostTransactionAsync as deprecated since ArangoDB 3.12 #501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark PostTransactionAsync as deprecated since ArangoDB 3.12 #501

wants to merge 1 commit into from

Conversation

DiscoPYF
Copy link
Collaborator

fix #496

@DiscoPYF DiscoPYF requested a review from rossmills99 February 17, 2025 15:53
@rossmills99
Copy link
Collaborator

@DiscoPYF This looks good, though I wonder about marking the tests as Obsolete. Are they really obsolete, if we are still supporting older version of ArangoDB?

@DiscoPYF
Copy link
Collaborator Author

DiscoPYF commented Mar 9, 2025

I wonder about marking the tests as Obsolete. Are they really obsolete, if we are still supporting older version of ArangoDB?

We get build warnings if we don't mark the tests as [Obsolete], as the test methods technically call deprecated code. Maybe I use #pragma warning disable instead to ignore the warnings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossmills99 rossmills99 rossmills99 approved these changes

Assignees
No one assigned
Labels
ArangoDB 3.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark PostTransactionAsync method as deprecated since ArangoDB 3.12
2 participants
@DiscoPYF @rossmills99