Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't control stops with MIDI #25

Open
moonpyk opened this issue Oct 9, 2023 · 11 comments
Open

Can't control stops with MIDI #25

moonpyk opened this issue Oct 9, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@moonpyk
Copy link

moonpyk commented Oct 9, 2023

Hello,

I've tried all possible combinations and CC #98 Aeolus control command don't seem to work.

Reading the source, I'm not sure

const int modeValue{ (value >> 4) & 0x03 >> 4 };
is gonna work.

Kind regards

@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

Hi,
Yeah, this obviously won't work - the 2nd shift by 4 bytes should not be there.

Archie3d added a commit that referenced this issue Oct 9, 2023
@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

I am not using this feature myself, so if you do, please let me know about any issues you find :)

@moonpyk
Copy link
Author

moonpyk commented Oct 9, 2023

Thanks a lot @Archie3d, that was quick, would be able to compile a Windows standalone binary in the coming days ? I haven't the toolchain on hands to try to see if it's better.

Cheers

@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

Here you go
Aeolus_standalone_win64_48f7ccdb.zip

@lewisalexander2020
Copy link

lewisalexander2020 commented Oct 9, 2023 via email

@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

could this be compiled for the mac also? ok, besides standalone updates, etc? lew

On 9 Oct 2023, at 21:37, Arthur Benilov @.***> wrote: Here you go Aeolus_standalone_win64_48f7ccdb.zip https://github.com/Archie3d/aeolus_plugin/files/12850427/Aeolus_standalone_win64_48f7ccdb.zip — Reply to this email directly, view it on GitHub <#25 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATQDNKNNBKCBSKTGOT7BJ2TX6RN7FAVCNFSM6AAAAAA5ZJTDBCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTG43TGMRYGM. You are receiving this because you are subscribed to this thread.

Sure, just need to make sure the fix works and then I'll make an official release build for all the platform.

@moonpyk
Copy link
Author

moonpyk commented Oct 9, 2023

So OK, it didn't fix the bug (3-4 bits won't control the amount of stops there is).

I honestly think this feature should be ditched as-is.

Using 4 different CC with the complete 0x00 - 0xFF value to adress the stops will work.

I'll try to work on that.

Thanks a lot @Archie3d for reacting so quickly.

@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

This control scheme comes from the original Aeolus, and some people wanted it (but obviously nobody actually used it so far). I'd rather make it fixed and perhaps added another more sane control scheme. This will make everyone happy 🙂.

@moonpyk
Copy link
Author

moonpyk commented Oct 9, 2023

The thing I currently plan to code :

  • CC 102-> Disables all stops
  • CC 103 -> Disables the stop at Value
  • CC 104 -> Enables the stop at Value
  • CC 105 -> Toggles the stop at Value

Midi CCs 102 to 105 don't have any usage concensus so should't clash.

@Archie3d
Copy link
Owner

Archie3d commented Oct 9, 2023

@moonpyk Sure, go for it!

@jerash
Copy link

jerash commented Dec 28, 2023

fwiw organ consoles have various ways of sending midi messages for stops control.
Most use note_on/note_off, some use CC messages. Most use the keyboard midi channel, some use a dedicated midi channel.
Anyway, whatever solution different than the current aeolus implementation is easier to deal with using midi mapping, as you can't cover any case unless you code a complete midi learn solution.

@Archie3d Archie3d added the bug Something isn't working label Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants