Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

further scale(s) / temperament features #26

Open
elpeh opened this issue Oct 24, 2023 · 3 comments
Open

further scale(s) / temperament features #26

elpeh opened this issue Oct 24, 2023 · 3 comments

Comments

@elpeh
Copy link

elpeh commented Oct 24, 2023

Hello,

missing a suitable electronic instrument for rehearsal, I'd like to use Aeolus (standalone on Mac) with 1/6 comma meantone temperament instead of 1/4 comma as implemented.

I took data from https://www.huygens-fokker.org/docs/scalesdir.txt, converted meansixth.scl into the frequency ratio format aeolus uses (and double checked meanquar.scl to fit the existing MeanQuart).
Attached is a untested patch to scale.cpp.

I don't know how exactly to build an extended version on Mac M1. Instructions somewhere? Could you build it for me (as I try to test as soon as possible).

Regarding temperament: Base is C fixed. It would be nice to be able to change that for non-equal temperament (my instrument has only 1/4 comma for meantone, but allows any semintone as base). Should be not too complicated to implement.

More extensive feature would be adding temperament definitions from e.g. files.

Thanks for your work on Aeolus, regards,
Lutz
aeolus_MeanSixth.patch

@lewisalexander2020
Copy link

lewisalexander2020 commented Oct 24, 2023 via email

@Archie3d
Copy link
Owner

Hi Lutz, thanks for the contribution,
Here is a precompiled macOS standalone build with your changes applied.

Aeolus_macOS_standalone_issue26_8d58081f.zip

The non-C-based scaling - I'd need to think how to show this nicely in the UI, because having a long list of scales does not look nice to me.

@elpeh
Copy link
Author

elpeh commented Oct 24, 2023

Great, thanks for the very fast action. Seems to work correctly (at least some frequencies tested with a tuner app are as expected).

Regarding base note: a further selector for semitones (maybe inactive for equal temp.)? This is necessary as additional parameter for Rankwave::createPipes / retunePipes, too, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants