Draft: Change Logging Feature Mode #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a new module called `ar_logger` where all functions related to logging are present. The goal here is also to get rid of the `disk_log` logging type causing sync issues on rsyslog and using a more conventional "Unix way" to store logs. The previous method using `disk_log` was using a wrap method, creating also two files ending with .siz and .idx to follow the logs. One of the important feature of `disk_log` is to repair logs, but it seems this feature is not used. Instead, using a simple append method with `logger_std_h` mode will make things easier when collecting logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates a new module called
ar_loggerwhere all functions related to logging are present. The goal here is also to get rid of thedisk_loglogging type causing sync issues on rsyslog and using a more conventional "Unix way" to store logs.The previous method using
disk_logwas using a wrap method, creating also two files ending with .siz and .idx to follow the logs. One of the important feature ofdisk_logis to repair logs, but it seems this feature is not used. Instead, using a simple append method withlogger_std_hmode will make things easier when collecting logs.