Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Issue" with "Show Friends In Your Lobby" Feature #147

Open
LobbyLC opened this issue Aug 26, 2024 · 2 comments
Open

"Issue" with "Show Friends In Your Lobby" Feature #147

LobbyLC opened this issue Aug 26, 2024 · 2 comments
Assignees
Labels
Bug Something isn't working Good First Issue A good place to start contributing to this project without going too deep.

Comments

@LobbyLC
Copy link

LobbyLC commented Aug 26, 2024

This may be more of a nitpick than a bug, but I believe an issue worth mentioning nonetheless. In a somewhat recent MCC Island update, the main lobby was merged with each game lobby, which means you could be in a Battle Box lobby while your friend is in a Sky Battle lobby, and you could both still be in the same instance. Poor explanation, but I'm sure you know what I mean.

The issue is, Island Utils wasn't updated to match this. If you open the navigator and click on any of the gamemodes, it'll post a new "Friends In Your Lobby" message in chat, even though you technically haven't changed instances - and yes, it's showing your friends in the Sky Battle lobby even when you move to the Battle Box lobby, as it technically should.

In my opinion, the ideal fix for this would be to only post the "Friends In Your Lobby" message in chat when you first join a main lobby (such as joining the server, or using /hub after a game ends), rather than posting one every time you select a different gamemode.

Here's a short video demonstrating the issue:

Friends.mp4

Side note, this issue can be reproduced on any Island Utils version, but in this demonstration, I am using the latest.

@LobbyLC
Copy link
Author

LobbyLC commented Aug 26, 2024

... Are these supposed to be bots? That's new. 🤦‍♂️

Repository owner deleted a comment Aug 26, 2024
Repository owner deleted a comment Aug 26, 2024
@LukynkaCZE
Copy link
Collaborator

... Are these supposed to be bots? That's new. 🤦‍♂️

Yep.. apparently those are thing now 😭

@LukynkaCZE LukynkaCZE added Bug Something isn't working Good First Issue A good place to start contributing to this project without going too deep. labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Good First Issue A good place to start contributing to this project without going too deep.
Projects
None yet
Development

No branches or pull requests

3 participants