Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for nil IdentityID case panics #162

Open
0xankit opened this issue Dec 5, 2022 · 0 comments
Open

test for nil IdentityID case panics #162

0xankit opened this issue Dec 5, 2022 · 0 comments

Comments

@0xankit
Copy link
Contributor

0xankit commented Dec 5, 2022

For equals method we should check if key comparing with is nil or not, else it will panic

{"+ve", fields{nil}, args{key{nil}}, true},
{"-ve", fields{nil}, args{key{testIdentity}}, false},
{"-ve", fields{testIdentity}, args{key{nil}}, false},
{"+ve", fields{testIdentity}, args{key{testIdentity}}, true},

func (key key) Equals(compareKey helpers.Key) bool {
if CompareKey, err := keyFromInterface(compareKey); err != nil {
return false
} else {
// TODO test nil IdentityID case
return key.IdentityID.Compare(CompareKey.IdentityID) == 0
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant