Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch of changes for package; Add Laravel 11 support #395

Merged
merged 16 commits into from
Apr 17, 2024

Conversation

Oleksandr-Moik
Copy link
Contributor

@Oleksandr-Moik Oleksandr-Moik commented Mar 17, 2024

Hi! First of all - sorry for such a big and dirty request)

Follows and inspired by #387 and additionally closes some issues:


Want to use this package for Laravel 11 - see comment


I found comment about "removing old versions" - is it still valid?

@Oleksandr-Moik
Copy link
Contributor Author

To see how test suites works - see here Oleksandr-Moik#1

@Oleksandr-Moik
Copy link
Contributor Author

Any suggestions and changes are welcome)

@redalpha01
Copy link

Looking forward to having this merged.

@Oleksandr-Moik
Copy link
Contributor Author

Hi, @Gummibeer. Can you review these changes, please?

@Oleksandr-Moik
Copy link
Contributor Author

Hi! If you want to test or if you need to use this package for Laravel 11, I decided to add a release tag v11.13 on my fork.

To use it, temporarily add this fork to the repositories property of your composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/Oleksandr-Moik/laravel-translatable.git"
        }
    ],

and then run the following command to install the package:

composer require "astrotomic/laravel-translatable:^11.13"

I will keep this tag for the future but do not forget to remove it when the main package receives support for the new Laravel version. After that, I plan to remove the tag in a few weeks so that your project depends on the official source and not my fork.

So if you plan to use it - subscribe on this pull request so I can notify you via GitHub.

Thanks for understanding!

@github-actions github-actions bot added the stale label Apr 15, 2024
@Oleksandr-Moik Oleksandr-Moik mentioned this pull request Apr 17, 2024
@Gummibeer Gummibeer changed the base branch from main to pr-395 April 17, 2024 11:30
@Gummibeer Gummibeer merged commit 4d4dd88 into Astrotomic:pr-395 Apr 17, 2024
3 checks passed
@Gummibeer Gummibeer mentioned this pull request Apr 17, 2024
@Oleksandr-Moik Oleksandr-Moik deleted the changes branch May 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Add PHPunit 11 support Add PHP versions to test matrix. Add Laravel11 support
4 participants