Skip to content

Commit 6b4c3ce

Browse files
committed
Update
1 parent 16b1384 commit 6b4c3ce

File tree

3 files changed

+0
-12
lines changed

3 files changed

+0
-12
lines changed

src/include/cxxopts.hpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1519,7 +1519,6 @@ CXXOPTS_IGNORE_WARNING("-Wnull-dereference")
15191519
CXXOPTS_DIAGNOSTIC_POP
15201520
#endif
15211521

1522-
// TODO: maybe default options should count towards the number of arguments
15231522
CXXOPTS_NODISCARD
15241523
bool
15251524
has_default() const noexcept
@@ -2355,7 +2354,6 @@ inline
23552354
void
23562355
OptionParser::parse_default(const std::shared_ptr<OptionDetails>& details)
23572356
{
2358-
// TODO: remove the duplicate code here
23592357
auto& store = m_parsed[details->hash()];
23602358
store.parse_default(details);
23612359
m_defaults.emplace_back(details->essential_name(), details->value().get_default_value());

src/utils/cJSON.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1735,7 +1735,6 @@ CJSON_PUBLIC(int) cJSON_GetArraySize(const cJSON *array)
17351735
child = child->next;
17361736
}
17371737

1738-
/* FIXME: Can overflow here. Cannot be fixed without breaking the API */
17391738

17401739
return (int)size;
17411740
}
@@ -2888,7 +2887,6 @@ CJSON_PUBLIC(cJSON_bool) cJSON_Compare(const cJSON * const a, const cJSON * cons
28882887
cJSON *b_element = NULL;
28892888
cJSON_ArrayForEach(a_element, a)
28902889
{
2891-
/* TODO This has O(n^2) runtime, which is horrible! */
28922890
b_element = get_object_item(b, a_element->string, case_sensitive);
28932891
if (b_element == NULL)
28942892
{
@@ -2901,8 +2899,6 @@ CJSON_PUBLIC(cJSON_bool) cJSON_Compare(const cJSON * const a, const cJSON * cons
29012899
}
29022900
}
29032901

2904-
/* doing this twice, once on a and b to prevent true comparison if a subset of b
2905-
* TODO: Do this the proper way, this is just a fix for now */
29062902
cJSON_ArrayForEach(b_element, b)
29072903
{
29082904
a_element = get_object_item(a, b_element->string, case_sensitive);

src/wasm_interface.cpp

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
#include <emscripten/bind.h>
22
#include <emscripten/val.h>
33
#include <vector>
4-
//#include <cstdio>
5-
//#include <stdexcept>
64
#include <string>
7-
//#include <algorithm>
8-
//#include <iostream>
9-
//#include <dirent.h>
10-
//#include <sys/stat.h>
115
#include "ncmcrypt.h"
126

137
using namespace emscripten;

0 commit comments

Comments
 (0)