Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy autocomplete URL is 404 #55

Closed
nickdos opened this issue Nov 3, 2016 · 4 comments
Closed

Legacy autocomplete URL is 404 #55

nickdos opened this issue Nov 3, 2016 · 4 comments
Assignees

Comments

@nickdos
Copy link
Contributor

nickdos commented Nov 3, 2016

A few legacy systems still send a request to:

http://bie.ala.org.au/search/auto.jsonp

Which now throws a 404.

Fix is to redirect the output of this URL to:

http://bie.ala.org.au/ws/search/auto.jsonp

either via UrlMappings.groovy or via a controller method.

nickdos added a commit that referenced this issue Nov 13, 2018
Legacy autocomplete requests get proxied to bie-index
@nickdos nickdos self-assigned this Nov 13, 2018
@nickdos
Copy link
Contributor Author

nickdos commented Nov 14, 2018

Available on test for QA

http://bie-test.ala.org.au/search/auto.jsonp?q=acacia+dealb

EDIT: link is giving an error - investigating... wrong URL... fixed
EDIT 2: still broken... bugger

NOTE that the jsonp callback feature is not implemented on bie-index and thus doesn't work here either, as it has been implemented as a proxy. This is only of concern to legacy apps as we are (should be) using CORS JSON only now.

nickdos added a commit that referenced this issue Nov 14, 2018
Used wrong config var in previous commit.
nickdos added a commit that referenced this issue Nov 14, 2018
@ansell suggested putting reader.close into finally, which should prevent too many resources being left open.
nickdos added a commit that referenced this issue Nov 14, 2018
@ansell
Copy link
Contributor

ansell commented Nov 21, 2018

This may also relate to AtlasOfLivingAustralia/ala-bootstrap3#8

@ansell
Copy link
Contributor

ansell commented Nov 21, 2018

The lack of JSONP support by bie-index seems to be still breaking the autocomplete by our main website search bar: https://bie.ala.org.au/ws/search/auto.jsonp?callback=jQuery112406428917128422043_1542757912505&q=test&limit=100&timestamp=1542757919528&_=1542757912506 returns JSON with no wrapped callback function, which the browser fails to interpret as JSONP, even though the results seem to look okay otherwise as a JSON document. An alternative to adding/fixing JSONP in bie-index may be to focus on fixing commonui and/or ala-bootstrap and switch them over to CORS+JSON rather than JSONP, as it seems to work already that way, just that the browser is expecting JSONP and fails after the results from bie come back successfully.

@ansell
Copy link
Contributor

ansell commented Nov 21, 2018

Closing this as https://bie-test.ala.org.au/search/auto.jsonp?q=acaci works for me.

@ansell ansell closed this as completed Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants