Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@org.atmosphere.config.service.Disconnect do not detect Android Chrome close Tab #32

Open
umbreak opened this issue Aug 24, 2015 · 6 comments

Comments

@umbreak
Copy link

umbreak commented Aug 24, 2015

Hello,

Atmosphere-play 2.1.2 with @ManagedService

When closing a tab with Android Chrome, the @Disconnect method is not fired.

AsyncSupportListener onClose is fired, but this is not in the context of the room, so it is not useful for me.

Try out the chat sample you provided with Chrome browser for Android and you will see it does not detect the closing of the tab (it does detect if in the URL bar I change the URL, but nothing else).

@umbreak
Copy link
Author

umbreak commented Aug 24, 2015

Checking a bit further, it is detected as a @org.atmosphere.config.service.Resume which is obviously wrong.

@jfarcand
Copy link
Member

@umbreak Which server are you using? That's the server that send this information to Atmosphere.

@umbreak
Copy link
Author

umbreak commented Aug 24, 2015

It works with Firefox desktop, Firefox mobile, chrome desktop, etc.

I am using directly Play (2.3.10) without any server in between (not Apache nor Lighthttp). And Play is using internally Netty

Maybe could be related with that issue:http://stackoverflow.com/questions/11755605/chrome-websocket-connection-not-closed-when-browser-closed ?

@umbreak
Copy link
Author

umbreak commented Aug 27, 2015

@jfarcand , some other suggestion or I should hack the onResume to detect when it is Chrome and force the Disconnect?

@jfarcand
Copy link
Member

@umbreak I don't have the cycle to look at it (for a couple of weeks at least, swamped with paying customers), but the issue seems to be related to the javascript, e.g the close message is not send by Chrome on Android. Check to see if this code is called on Android

@jfarcand jfarcand reopened this Aug 27, 2015
@umbreak
Copy link
Author

umbreak commented Nov 3, 2015

Yes. As you suggested, the _disconnect method is not being called for Android Chrome when closing the browser though the android apps panel. Only in case of changing the URL on the browser, that method is called.

What is the status of this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants