Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider a user setting or a different default other than install #22

Open
AddictArts opened this issue Sep 15, 2016 · 6 comments
Open

Comments

@AddictArts
Copy link

Accidentally hitting F9 when it is an npm install is a bummer in a way.

@AddictArts AddictArts changed the title Consider a different default instead of install or a setting to change it Consider a user setting or a different default other than install Sep 15, 2016
@omeryagmurlu
Copy link

+1 this is a needed feature

@AddictArts
Copy link
Author

AddictArts commented Aug 3, 2017

I ended up just changing apm-npm.js line 45 name: pkg.engines && pkg.engines.atom ? 'apm: clean' : 'npm: clean', It used to have install where clean is now. Line 47 as well args: [ 'run', 'clean' ],

@Hativ
Copy link

Hativ commented Aug 20, 2017

+1

@noseglid
Copy link
Member

If we're changing this, we need to know what we should change to. What would a "sane" default be?

@Hativ
Copy link

Hativ commented Aug 21, 2017

It should be a setting option. Nothing should be defined as default (but if required I would choose "start"). If no default is defined by the user when executing build the target selection should be shown. The benefit here is the ability to define the default target by myself. I want to run the script "build" in 99% of all cases (automatically on save), so that should be my default.

@noseglid
Copy link
Member

Making it configurable should be relatively straight forward. This package needs to check it's configuration - if any of the returned targets from npm is equal to the configuration, put that first in the list.

Having it show the select target list if no default has been set needs a change in the build core package and might be a bit more involved. All though worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants