Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters model #13

Open
AugustoMarcelo opened this issue Feb 7, 2022 · 5 comments
Open

Characters model #13

AugustoMarcelo opened this issue Feb 7, 2022 · 5 comments
Labels
question Further information is requested

Comments

@AugustoMarcelo
Copy link
Owner

Hey, everyone!

I'm working on the characters model and I'm thinking about what data would be good to have. This is the minimum that all characters will have:

  • ID
  • Name
  • Bio
  • Posters
  • Related Movies
  • Related TV Shows
@AugustoMarcelo AugustoMarcelo added the question Further information is requested label Feb 7, 2022
@KristofKekesi
Copy link

I think it would be better to have two types of films and two types of tv shows.

In related should be of course the related, except the own films and tv series. That would be under own.

So for Captain America related films would be for example the Avengers films, and for own films the Captain America trilogy.

@AugustoMarcelo
Copy link
Owner Author

@KristofKekesi It's a good point. I'll use an attribute to differentiate the data.

@AugustoMarcelo
Copy link
Owner Author

Here is an initial example of the character modeled. The TV Shows will also be added.

{
  "id": 1,
  "name": "Tony Stark",
  "aka": "Iron Man",
  "bio": "Genius inventor Tony Stark continued his father Howard Stark's weaponry business after his parents' untimely deaths and flew it to even greater heights of innovation. While in Afghanistan to demonstrate a new missile for the U.S. military, Stark's convoy came under fire by a terrorist group known as the Ten Rings and he was severely wounded. Taken prisoner by the group, Stark awoke in their headquarters to learn that shrapnel near his heart had nearly cost him his life, but swift action by scientist and fellow prisoner Ho Yinsen—who had inserted a powerful electromagnet in Stark's chest—would prolong it temporarily.",
  "posters": [
    "https://terrigen-cdn-dev.marvel.com/content/prod/1x/002irm_ons_crd_02.jpg",
    "https://terrigen-cdn-dev.marvel.com/content/prod/1x/002irm_ons_crd_03.jpg"
  ],
  "movies": [
    {
      "movie": {
        "title": "Iron Man",
        "id": 1,
        "poster": "https://raw.githubusercontent.com/AugustoMarcelo/mcuapi/master/covers/iron-man.jpg"
      },
      "own_movie": true,
      "appearance": "major appearance"
    },
    {
      "movie": {
        "title": "The Incredible Hulk",
        "id": 2,
        "poster": "https://raw.githubusercontent.com/AugustoMarcelo/mcuapi/master/covers/hulk.jpg"
      },
      "own_movie": false,
      "appearance": "post-credits"
    }
  ]
}

@AbdirayimovS
Copy link

Hi @AugustoMarcelo,
I hope you are doing well!

It seems the API is not in working mode. I can not do requests. I need Marvel characters dataset. How can I get it?
Looking forward for your reply!

Sincerely,

@AugustoMarcelo
Copy link
Owner Author

Hi, @AbdirayimovS

Sorry for the delay, I've been a little busy in the last weeks. The API is working for me. Not sure what type of error are you getting, but feel free to share with me and I can help you. Regarding the characters endpoint, it's not ready. I'm not sure when I'll be able to get it live, but it shouldn't take so much. It's been a while since I worked in the code, but I had a great progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants