Skip to content

Commit 5f815e4

Browse files
authored
Change Contributing Guidelines (#17)
1 parent 1af7aa2 commit 5f815e4

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,8 @@ Here are some important resources:
2828
## Pull Request Guidelines:
2929
* Please name your pull request appropriately as it will become the commit message.
3030
* Please leave a meaningful description on the Pull Request so the reviewers have better context when reviewing.
31-
* Please assign reviewers once the CI checks have passed.
31+
* Please assign reviewers once the CI checks have passed. + Please also tag the reviewers in a message on the general slack
32+
* PRs must be reviewed by another member of the team before being checked by the maintainer team
3233
* Please use github commenting for code review discussions and resolve the issues before approving the pull request and merging it.
3334
* All pull requests must include counterpart tests, as long as the folder structure above is honored CI will automatically run them. Test can also be run locally using pytest
3435
* Commits should be squashed when merging a PR and no merge commits should be created.

0 commit comments

Comments
 (0)