Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viewerable from metadata should be doc.getRoot().findByGuid(viewableId).parent #16

Open
xiaodongliang opened this issue Apr 10, 2020 · 1 comment

Comments

@xiaodongliang
Copy link

xiaodongliang commented Apr 10, 2020

With guid of metadata, we can find viewerable data by doc.getRoot().findByGuid(viewableId), but the viewerable that can be used with loadDocumentNode is its parent.

so the line below should be fixed to

doc.getRoot().findByGuid(viewableId).parent

https://github.com/Autodesk-Forge/learn.forge.viewhubmodels/blob/master/js/ForgeViewer.js#L39-L42

@xiaodongliang
Copy link
Author

xiaodongliang commented Apr 19, 2020

get parent can only solve the scenario for view in non- BIM 360 Plan folder. To compatible with Plan folder, need to prepare correct version urn and view guid on server side. This PR completes: #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant