Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds with a pinned Docker label fail mysteriously #24

Open
blowery opened this issue Jun 6, 2018 · 2 comments
Open

Builds with a pinned Docker label fail mysteriously #24

blowery opened this issue Jun 6, 2018 · 2 comments

Comments

@blowery
Copy link
Contributor

blowery commented Jun 6, 2018

When trying to build the original code in Automattic/wp-calypso#25321, dserve would bomb with the following log:

Time=2018-06-06T20:08:01.651Z | ---------------- DOCKER START ----------------
Time=2018-06-06T20:08:07.378Z | Step 1/16 : FROM node:8.11.2@sha256:321655aeb195b7946e9a29d28453388751389e8ced66b4dea772ae76a6985309
Time=2018-06-06T20:08:07.902Z | { status: 'Pulling from library/node', id: '8.11.2' }
Time=2018-06-06T20:08:08.182Z | Encountered error when building image

That PR was trying to pin the docker images to make builds more stable. Currently we're using labels from docker, which can change as the underlying OS takes patches.

Renovate (the new dependency updating tool) takes care of creating new PRs as the docker image associated with the label changes.

It's not critical that this get fixed (we decided to stick with plain labels, they've worked just fine so far), but it might be good to understand what went wrong.

@dmsnell
Copy link
Member

dmsnell commented Jun 7, 2018

Can you provide a link to the commit where this was breaking? I don't understand the title or description - can you fill up the description so we can get some context and understanding of what actually broke?

@blowery
Copy link
Contributor Author

blowery commented Jun 8, 2018

@dmsnell description updated

@blowery blowery changed the title Builds with a pinned Docker SHA fail mysteriously Builds with a pinned Docker label fail mysteriously Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@blowery @dmsnell and others