Podcast feed: Prevent fatals when passing invalid arg to XML parser (#45498)

Author: tbradsha

projects/plugins/jetpack/_inc/lib/class-jetpack-podcast-feed-locator.php

@@ -37,7 +37,7 @@ private function is_podcast_feed( $file ) {
 			return true;
 		}
 
-		$feed_dom = $this->safely_load_xml( $file->body );
+		$feed_dom = $this->safely_load_xml( (string) $file->body );
 
 		// Do this as either/or but prioritise the itunes namespace. It's pretty likely
 		// that it's a podcast feed we've found if that namespace is present.
@@ -48,9 +48,13 @@ private function is_podcast_feed( $file ) {
 	 * Safely loads an XML file
 	 *
 	 * @param string $xml A string of XML to load.
-	 * @return DOMDocument|false A restulting DOM document or `false` if there is an error.
+	 * @return DOMDocument|false A resulting DOM document or `false` if there is an error.
 	 */
 	private function safely_load_xml( $xml ) {
+		if ( empty( $xml ) ) {
+			return false;
+		}
+
 		$disable_entity_loader = PHP_VERSION_ID < 80000;
 
 		if ( $disable_entity_loader ) {

projects/plugins/jetpack/changelog/fix-jetpack-fatals_when_passing_invalid_arg_to_xml_parser

@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Podcast feed: Prevent fatals when content is empty.