Forms: Replace 3 count queries with single optimized endpoint

Reduces from 3 separate REST requests to 1 optimized database query with caching.

Related: #45339

Author: lezama

projects/packages/forms/changelog/optimize-inbox-counts

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Forms: replace 3 separate count queries with single optimized counts endpoint.

projects/packages/forms/src/contact-form/class-contact-form-endpoint.php

@@ -254,6 +254,16 @@ public function register_routes() {
 				'callback'            => array( $this, 'get_forms_config' ),
 			)
 		);
+
+		register_rest_route(
+			$this->namespace,
+			$this->rest_base . '/counts',
+			array(
+				'methods'             => \WP_REST_Server::READABLE,
+				'permission_callback' => array( $this, 'get_items_permissions_check' ),
+				'callback'            => array( $this, 'get_status_counts' ),
+			)
+		);
 	}
 
 	/**
@@ -302,6 +312,49 @@ static function ( $post_id ) {
 		);
 	}
 
+	/**
+	 * Retrieves status counts for inbox, spam, and trash in a single optimized query.
+	 *
+	 * @param WP_REST_Request $request Full data about the request.
+	 * @return WP_REST_Response Response object on success.
+	 */
+	public function get_status_counts( $request ) { // phpcs:ignore VariableAnalysis.CodeAnalysis.VariableAnalysis.UnusedVariable
+		global $wpdb;
+
+		$cache_key     = 'jetpack_forms_status_counts';
+		$cached_result = get_transient( $cache_key );
+		if ( false !== $cached_result ) {
+			return rest_ensure_response( $cached_result );
+		}
+
+		// phpcs:disable WordPress.DB.DirectDatabaseQuery.DirectQuery,WordPress.DB.DirectDatabaseQuery.NoCaching
+		$counts = $wpdb->get_row(
+			$wpdb->prepare(
+				"SELECT
+				SUM(CASE WHEN post_status IN ('publish', 'draft') THEN 1 ELSE 0 END) as inbox,
+				SUM(CASE WHEN post_status = %s THEN 1 ELSE 0 END) as spam,
+				SUM(CASE WHEN post_status = %s THEN 1 ELSE 0 END) as trash
+				FROM $wpdb->posts
+				WHERE post_type = %s",
+				'spam',
+				'trash',
+				'feedback'
+			),
+			ARRAY_A
+		);
+		// phpcs:enable
+
+		$result = array(
+			'inbox' => (int) ( $counts['inbox'] ?? 0 ),
+			'spam'  => (int) ( $counts['spam'] ?? 0 ),
+			'trash' => (int) ( $counts['trash'] ?? 0 ),
+		);
+
+		set_transient( $cache_key, $result, 30 );
+
+		return rest_ensure_response( $result );
+	}
+
 	/**
 	 * Adds the additional fields to the item's schema.
 	 *

projects/packages/forms/src/dashboard/hooks/use-inbox-data.ts

@@ -1,8 +1,10 @@
 /**
  * External dependencies
  */
+import apiFetch from '@wordpress/api-fetch';
 import { useEntityRecords } from '@wordpress/core-data';
 import { useDispatch, useSelect } from '@wordpress/data';
+import { useEffect, useMemo, useState } from '@wordpress/element';
 import { useSearchParams } from 'react-router';
 /**
  * Internal dependencies
@@ -36,6 +38,7 @@ interface UseInboxDataReturn {
 	totalItemsTrash: number;
 	records: FormResponse[];
 	isLoadingData: boolean;
+	isLoadingCounts: boolean;
 	totalItems: number;
 	totalPages: number;
 	selectedResponsesCount: number;
@@ -77,52 +80,45 @@ export default function useInboxData(): UseInboxDataReturn {
 
 	const records = ( rawRecords || [] ) as FormResponse[];
 
-	const { isResolving: isLoadingInboxData, totalItems: totalItemsInbox = 0 } = useEntityRecords(
-		'postType',
-		'feedback',
-		{
-			page: 1,
-			search: '',
-			...currentQuery,
-			status: 'publish,draft',
-			per_page: 1,
-			_fields: 'id',
-		}
-	);
+	const countsQueryKey = useMemo( () => {
+		return JSON.stringify( {
+			status: statusFilter,
+			parent: currentQuery?.parent,
+			search: currentQuery?.search,
+			after: currentQuery?.after,
+			before: currentQuery?.before,
+		} );
+	}, [
+		statusFilter,
+		currentQuery?.parent,
+		currentQuery?.search,
+		currentQuery?.after,
+		currentQuery?.before,
+	] );
 
-	const { isResolving: isLoadingSpamData, totalItems: totalItemsSpam = 0 } = useEntityRecords(
-		'postType',
-		'feedback',
-		{
-			page: 1,
-			search: '',
-			...currentQuery,
-			status: 'spam',
-			per_page: 1,
-			_fields: 'id',
-		}
-	);
+	const [ counts, setCounts ] = useState( { inbox: 0, spam: 0, trash: 0 } );
+	const [ isLoadingCounts, setIsLoadingCounts ] = useState( false );
 
-	const { isResolving: isLoadingTrashData, totalItems: totalItemsTrash = 0 } = useEntityRecords(
-		'postType',
-		'feedback',
-		{
-			page: 1,
-			search: '',
-			...currentQuery,
-			status: 'trash',
-			per_page: 1,
-			_fields: 'id',
-		}
-	);
+	useEffect( () => {
+		const fetchCounts = async () => {
+			setIsLoadingCounts( true );
+			const response = await apiFetch< { inbox: number; spam: number; trash: number } >( {
+				path: '/wp/v2/feedback/counts',
+			} );
+			setCounts( response );
+			setIsLoadingCounts( false );
+		};
+
+		fetchCounts();
+	}, [ countsQueryKey, totalItems ] );
 
 	return {
-		totalItemsInbox,
-		totalItemsSpam,
-		totalItemsTrash,
+		totalItemsInbox: counts.inbox,
+		totalItemsSpam: counts.spam,
+		totalItemsTrash: counts.trash,
 		records,
-		isLoadingData:
-			isLoadingRecordsData || isLoadingInboxData || isLoadingSpamData || isLoadingTrashData,
+		isLoadingData: isLoadingRecordsData,
+		isLoadingCounts,
 		totalItems,
 		totalPages,
 		selectedResponsesCount,