Address lazy-load WP_User behavior introduced WP 6.9 (#45450)

Author: tbradsha

projects/packages/stats/changelog/fix-tests-wp_user_lazy_load

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Handle lazy-loading of WP_User object properties.

projects/packages/stats/src/class-main.php

@@ -120,8 +120,11 @@ public static function jetpack_is_dnt_enabled() {
 	public static function map_meta_caps( $caps, $cap, $user_id ) {
 		// Map view_stats to exists.
 		if ( 'view_stats' === $cap ) {
-			$user        = new WP_User( $user_id );
-			$user_role   = array_shift( $user->roles );
+			$user = new WP_User( $user_id );
+			// WordPress 6.9 introduced lazy-loading of some WP_User properties, including `roles`.
+			// It also made said properties protected, so we can't modify keys directly.
+			$user_roles  = $user->roles;
+			$user_role   = array_shift( $user_roles ); // Work with the copy
 			$stats_roles = Options::get_option( 'roles' );
 
 			// Is the users role in the available stats roles?

projects/packages/sync/changelog/fix-tests-wp_user_lazy_load

@@ -0,0 +1,4 @@
+Significance: patch
+Type: changed
+
+Handle lazy-loading of WP_User object properties.

projects/packages/sync/src/class-functions.php

@@ -604,7 +604,21 @@ public static function get_is_fse_theme() {
 	 */
 	public static function json_wrap( &$any, $seen_nodes = array() ) {
 		if ( is_object( $any ) ) {
-			$input        = get_object_vars( $any );
+			$input = get_object_vars( $any );
+
+			// WordPress 6.9 introduced lazy-loading of WP_User `roles`, `caps`, and `allcaps` properties.
+			// It also made said properties protected, so we need to access them and set them as keys manually.
+			if ( $any instanceof \WP_User ) {
+				$roles   = $any->roles;
+				$caps    = $any->caps;
+				$allcaps = $any->allcaps;
+
+				// For WordPress <6.8 the below are redundant. :shrug:
+				$input['roles']   = $roles;
+				$input['caps']    = $caps;
+				$input['allcaps'] = $allcaps;
+			}
+
 			$input['__o'] = 1;
 		} else {
 			$input = &$any;

projects/plugins/jetpack/changelog/fix-tests-wp_user_lazy_load

@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Sync: Handle lazy-loading of WP_User object properties.

projects/plugins/jetpack/tests/php/sync/Jetpack_Sync_Users_Test.php

@@ -35,8 +35,13 @@ public function test_insert_user_is_synced() {
 		// The regular user object doesn't have allowed_mime_types
 		unset( $server_user->data->allowed_mime_types );
 
-		unset( $user->allcaps['subscriber'] );
-		unset( $user->allcaps['level_0'] );
+		// WordPress 6.9 introduced lazy-loading of some WP_User properties.
+		// It also made said properties protected, so we can't modify keys directly.
+		$allcaps = $user->allcaps; // This triggers lazy loading
+		unset( $allcaps['subscriber'] );
+		unset( $allcaps['level_0'] );
+		$user->allcaps = $allcaps;
+
 		$this->assertEqualsObject( $user, $server_user, 'The replicastore user must equal the initial user.' );
 
 		$event = $this->server_event_storage->get_most_recent_event( 'jetpack_sync_register_user' );