Forms: Optimize has_feedback() query for better performance (#45361)

* Forms: Optimize has_feedback() query for better performance

* Return $posts->have_posts() instead

---------

Co-authored-by: Enej Bajgoric <[email protected]>

Author: lezama

projects/packages/forms/changelog/update-optimize-has-feedback-query

@@ -0,0 +1,4 @@
+Significance: patch
+Type: fixed
+
+Optimize has_feedback() query to improve dashboard load performance by limiting query to fetch only 1 ID instead of loading all feedback posts.

projects/packages/forms/src/dashboard/class-dashboard.php

@@ -150,12 +150,17 @@ public function render_dashboard() {
 	public function has_feedback() {
 		$posts = new \WP_Query(
 			array(
-				'post_type'   => 'feedback',
-				'post_status' => array( 'publish', 'draft', 'spam', 'trash' ),
+				'post_type'              => 'feedback',
+				'post_status'            => array( 'publish', 'draft', 'spam', 'trash' ),
+				'posts_per_page'         => 1,
+				'fields'                 => 'ids',
+				'no_found_rows'          => true,
+				'update_post_meta_cache' => false,
+				'update_post_term_cache' => false,
+				'suppress_filters'       => true,
 			)
 		);
-
-		return $posts->found_posts > 0;
+		return $posts->have_posts();
 	}
 
 	/**