Skip to content

PCIOS-798: Mini Player Bar Empty After Opening via Notification Tap#4692

Draft
pocketcasts wants to merge 1 commit into
trunkfrom
pcios-798/fix-mini-player-empty-on-notification-tap
Draft

PCIOS-798: Mini Player Bar Empty After Opening via Notification Tap#4692
pocketcasts wants to merge 1 commit into
trunkfrom
pcios-798/fix-mini-player-empty-on-notification-tap

Conversation

@pocketcasts

Copy link
Copy Markdown
Contributor

Resolves https://linear.app/a8c/issue/PCIOS-798/mini-player-bar-empty-after-opening-via-notification-tap

Summary

  • When the app returns from background on iOS 26+ (Liquid Glass), the mini player bar shows empty content because setupForEpisode() short-circuits when the episode hasn't changed, and showMiniPlayer() returns early because the tab accessory already exists. No view gets setNeedsLayout/setNeedsDisplay, so after iOS purges rendering state during backgrounding, the content stays blank until a user interaction forces a layout pass.
  • Added a dedicated appDidBecomeActive() handler that, under Liquid Glass, forces layout and display invalidation on the mini player's key views after the normal playback state update.

Changes

  • Changed didBecomeActiveNotification observer from playbackStateDidChange to new appDidBecomeActive method
  • appDidBecomeActive() calls playbackStateDidChange() then forces setNeedsLayout/setNeedsDisplay on the title label, progress view, artwork, and root view, followed by layoutIfNeeded() — only under Liquid Glass when the tab accessory is already installed

Verification

  • Lint: PASS
  • Tests: FAIL — pre-existing build failure in CarPlaySceneDelegate+Convert.swift (CPPlaybackConfiguration not in current SDK). Unrelated to this change.
  • Diff review: PASS — single file changed, minimal and targeted fix

Confidence

MEDIUM — The fix addresses the clear code path where no visual invalidation occurs after background return under Liquid Glass. Cannot verify on-device without the specific iOS 26 environment.

Known Issues

  • Pre-existing build failure in CarPlaySceneDelegate+Convert.swift — not related to this change.

This PR was created autonomously by linear-solver.
Triage complexity: medium | Linear issue

@dangermattic

Copy link
Copy Markdown
Collaborator
1 Message
📖 This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao requested a review from kean July 7, 2026 15:37
@SergioEstevao SergioEstevao added [Type] Bug Used for issues where something is not functioning as intended. [Project] Liquid Glass labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Project] Liquid Glass [Type] Bug Used for issues where something is not functioning as intended.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants