Skip to content

TV: Enable Firebase Analytics on tvOS#4691

Merged
SergioEstevao merged 5 commits into
trunkfrom
sergio/pc-tv/enable_firebase_analytics
Jul 7, 2026
Merged

TV: Enable Firebase Analytics on tvOS#4691
SergioEstevao merged 5 commits into
trunkfrom
sergio/pc-tv/enable_firebase_analytics

Conversation

@SergioEstevao

@SergioEstevao SergioEstevao commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Enables Firebase Analytics on the tvOS (Pocket Casts TV) app, which was previously excluded from analytics tracking.

  • Adds the FirebaseAnalyticsWithoutAdIdSupport product to the module dependencies.
  • Removes the !os(tvOS) guards in AnalyticsHelper so the existing analytics path is reused on tvOS instead of being compiled out.
  • Adds the -FIRAnalyticsDebugEnabled launch argument to the TV app scheme for local debugging of analytics events.

To test

  1. Run the Pocket Casts TV App scheme on the tvOS simulator.
  2. Navigate around the app to trigger tracked events.
  3. Confirm analytics events are being logged (the -FIRAnalyticsDebugEnabled launch arg surfaces Firebase debug logging in the console).

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

SergioEstevao and others added 2 commits July 7, 2026 09:31
@SergioEstevao
Enable firebase analytics
2899b10
@SergioEstevao @claude
Fix leading space in FIRAnalyticsDebugEnabled launch argument
054ba27 
The launch argument had a stray leading space that would prevent the
flag from being recognized at launch. Match the formatting of the other
scheme arguments.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@dangermattic

dangermattic commented Jul 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator
2 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved.

If the change includes adding, removing, or editing a dependency please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

If the change to the Package.swift did not modify dependencies, ignoring this warning should be safe, but we recommend double checking and running the package resolution just in case.
.
⚠️ This PR is assigned to the milestone 8.16. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao added this to the 8.16 milestone Jul 7, 2026
@SergioEstevao SergioEstevao marked this pull request as ready for review July 7, 2026 08:39
@SergioEstevao SergioEstevao requested a review from a team as a code owner July 7, 2026 08:39
@SergioEstevao SergioEstevao requested review from Copilot and kean and removed request for a team July 7, 2026 08:39
Copilot AI reviewed Jul 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Firebase Analytics for the Pocket Casts tvOS app by reusing the existing analytics plumbing that was previously compiled out on tvOS, and by wiring the tvOS target up with the correct Firebase Analytics SPM product.

Changes:

  • Enable Firebase imports and Firebase.Analytics.logEvent calls on tvOS by removing the !os(tvOS) compilation guards in AnalyticsHelper.
  • Add FirebaseAnalyticsWithoutAdIdSupport to the Pocket Casts TV App’s SwiftPM dependencies.
  • Add the -FIRAnalyticsDebugEnabled launch argument to the shared Pocket Casts TV App Xcode scheme for local analytics debugging.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
podcasts/AnalyticsHelper.swift Removes tvOS compile guards so the existing Firebase event logging path can run on tvOS.
podcasts.xcodeproj/xcshareddata/xcschemes/Pocket Casts TV App.xcscheme Adds a Firebase analytics debug launch argument for the TV app scheme.
Modules/Package.swift Adds FirebaseAnalyticsWithoutAdIdSupport to the TV app Xcode-support target dependencies.

Comment thread podcasts.xcodeproj/xcshareddata/xcschemes/Pocket Casts TV App.xcscheme
@SergioEstevao SergioEstevao enabled auto-merge July 7, 2026 15:08
@SergioEstevao SergioEstevao merged commit cf38784 into trunk Jul 7, 2026
3 checks passed
@SergioEstevao SergioEstevao deleted the sergio/pc-tv/enable_firebase_analytics branch July 7, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@kean kean kean approved these changes

Assignees

No one assigned

Labels

[Project] tvOS

Projects

None yet

Milestone

8.16 ❄️

Development

Successfully merging this pull request may close these issues.

4 participants

@SergioEstevao @dangermattic @kean