Ensure that we display an appropriate error message for when there is .maintenance file#3948
Merged
Conversation
Collaborator
📊 Performance Test ResultsComparing 9e71055 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
Author
bcotrim
requested changes
Jul 3, 2026
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
I suggest moving the checkMaintenanceFile to the CLI so it covers the app, cli and agent workflows.
The app can still catch the error to display the correct Maintenance file error message.
What do you think?
Contributor
Author
|
Thanks for the review @bcotrim - I applied your suggestion! |
gavande1
reviewed
Jul 7, 2026
gavande1
reviewed
Jul 7, 2026
gavande1
approved these changes
Jul 7, 2026
gavande1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing the concerns. I tested this, and it looks good to me. ✅
Contributor
Author
|
Thanks for the review @gavande1 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related issues
Fixes STU-1847
How AI was used in this PR
It was used to implement the solution.
Proposed Changes
This PR ensures that when there is a .maintenance file and a fresh lock, the appropriate message is displayed to the user if they try to stop and start the site. It detects the lock that is fresher than 10 minutes and after 10 minutes, WordPress will ignore the stale lock file.
Testing Instructions
npm startmode and the lock will expire within 10 minutes:
rm ~/Studio/<your-site-name>/.maintenancePre-merge Checklist