Skip to content

Fix liberate_extract timeout#4095

Merged
nightnei merged 1 commit into
trunkfrom
fixLiberateTimeout
Jul 7, 2026
Merged

Fix liberate_extract timeout#4095
nightnei merged 1 commit into
trunkfrom
fixLiberateTimeout

Conversation

@nightnei

@nightnei nightnei commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Related issues

How AI was used in this PR

AI helped to implement, and I checked

Proposed Changes

Let's increase the default mcp 60-second timeout since liberate_extract takes a long time. It will prevent redundant checks of the status, avoid flooding the output in the terminal, and save tokens.

Screenshot 2026-07-06 at 19 23 27

Testing Instructions

  1. npm run cli:build
  2. node apps/cli/dist/cli/main.mjs code
  3. /liberate https://neicss.wixsite.com/sunflower-valley-exp
  4. Assert that you see one request and response that it's completed, instead of error and checkign status a lot of times
BEFORE AFTER
Screenshot 2026-07-06 at 19 25 28 Screenshot 2026-07-06 at 19 24 46

@nightnei nightnei requested a review from sejas July 6, 2026 18:26
@nightnei nightnei self-assigned this Jul 6, 2026
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 699fd27 vs trunk

app-size

Metric trunk 699fd27 Diff Change
App Size (Mac) 1411.75 MB 1411.75 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 699fd27 Diff Change
load 1113 ms 1111 ms 2 ms ⚪ 0.0%

site-startup

Metric trunk 699fd27 Diff Change
siteCreation 6502 ms 7011 ms +509 ms 🔴 7.8%
siteStartup 2395 ms 2396 ms +1 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to increase the timeout. However, is a bump from 60 to 600 needed here?

@nightnei

nightnei commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Makes sense to increase the timeout. However, is a bump from 60 to 600 needed here?

Yeah, I don't anticipate any issues with it, and the MCP should work w/o errors, but some websites are tricky and can take quite a while to extract.

@nightnei nightnei merged commit 7a4bf5b into trunk Jul 7, 2026
12 checks passed
@nightnei nightnei deleted the fixLiberateTimeout branch July 7, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants