Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding button styles in child themes #8643

Closed
wants to merge 3 commits into from

Conversation

merkushin
Copy link
Member

@merkushin merkushin commented Jan 28, 2025

Fixes #8628

When applying global styles on top of block styles, the fundamental problem is that block styles take precedence, and so global styles aren’t applied.

A better explanation of the issue and exploration on ways to fix it: p6rkRX-6hi-p2

Changes proposed in this Pull Request:

Remove styling for the block as it has higher priority to Global Styles.

Testing:

  • Test the Blockbase theme before/after.
  • Test a child theme, Marl, for example, adding Global Styles for buttons.

Screenshots

Blockbase before:
blockbase - before

Blockbase after:
blockbase - after

Marl before:
marl - before

Marl after:
marl - after

Related issue(s):

Copy link
Contributor

github-actions bot commented Jan 28, 2025

Preview changes

I've detected changes to the following themes in this PR: Blockbase, Marl.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.
Child themes are dependent on their parent themes. You will have to install the parent theme as well for the preview to work correctly.

@merkushin merkushin requested review from fushar, pkevan and a team January 29, 2025 07:19
@merkushin merkushin closed this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button Styling Issue in Marl Theme: Button Text and Background
1 participant