Blockbase: style variation opt-out not always working

[pkevan]

Quick summary

When running the Gutenberg plugin within a site, the functionality to opt-out of style variations from a parent theme no longer functions as expected.

This is due to the WP_REST_Global_Styles_Controller now being WP_REST_Global_Styles_Controller_Gutenberg and therefore https://github.com/Automattic/themes/blob/trunk/blockbase/inc/rest-api.php#L25 is not longer triggered.

Steps to reproduce

Themes which use optOutOfParentStyleVariations should not show parent theme style variations.

Possible to reproduce on Simple sites, and presumably Atomic but could not test this easily.

Site owner impact

More than 60% of the total website/platform users

Severity

Major

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

Simple, Atomic

[merkushin]

Triage result:
I confirm, in a child theme (Marl), it tries to remove "Ruby Wine" palette, but it is still there.

Tested on a Simple site.

Assigning to @pkevan as he's already working on it.

[pkevan]

Triage result: I confirm, in a child theme (Marl), it tries to remove "Ruby Wine" palette, but it is still there.

Tested on a Simple site.

Assigning to @pkevan as he's already working on it.

This is something different - haven't dived into that specific functionality as yet but can't see how that option is used.

[merkushin]

Ah, I see, I need to retest it with Kingsley and/or Jackson theme.
I'll do it shortly.

[merkushin]

@pkevan

This is something different - haven't dived into that specific functionality as yet but can't see how that option is used.

Do we need a separate issue for that?

[merkushin]

Confirmed: for jackson, it uses "optOutOfParentStyleVariations": true, but has all the variations from Blockbase on a Simple site.

[pkevan]

@pkevan

This is something different - haven't dived into that specific functionality as yet but can't see how that option is used.

Do we need a separate issue for that?

Yes, probably best to, as it uses a different custom option to attempt to remove individual style variations.