Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Theme Layover: Title Block Invisible In Editor #8667

Closed
mxhassani opened this issue Jan 30, 2025 · 8 comments
Closed

Theme Layover: Title Block Invisible In Editor #8667

mxhassani opened this issue Jan 30, 2025 · 8 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Pri] Low [Status] Auto-allocated [Type] Bug Something isn't working

Comments

@mxhassani
Copy link

Quick summary

When creating a post or a page, the title (and its placeholder) in the title block isn't visible.

Image

When selecting it:

Image

This is caused by the fact it's using the same color as the background color as the editor.

Steps to reproduce

  1. Activate Layover
  2. Create a new post
    The usual location of the title is clickable and editable, but not visible.
    Also replicable on the demo site.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Minor

What other impact(s) does this issue have?

No revenue impact

If a workaround is available, please outline it here.

Enabling Show template addresses it.

The source of the issue is this CSS code:
color: var(--wp--preset--color--foreground); that's inline on the editor.
It can be changed to color: var(--wp--preset--color--secondary); for a quick fix.

Platform (Simple and/or Atomic)

Simple, Atomic

@mxhassani
Copy link
Author

mxhassani commented Jan 30, 2025

9353054-zen

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 9353054-zen

Sorry, something went wrong.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". label Jan 30, 2025
@fushar
Copy link
Contributor

fushar commented Jan 31, 2025

@iamtakashi / @henriqueiamarino could you look into this issue? I see this is a recently launched theme. Thanks!

@iamtakashi
Copy link
Contributor

iamtakashi commented Jan 31, 2025

@henriqueiamarino I think all the headings and the links should use background and override the colour of them to foreground where we need in the templates. Are you happy to make a PR?

@henriqueiamarino
Copy link
Collaborator

Thanks @fushar and @iamtakashi. This one is tricky because it has a dark Home and a light Single template. Anyway, I'll think about it and find a solution.

@supernovia
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO

Image Image

📌 ACTIONS

  • Triaged

@henriqueiamarino since only the post/page editor are affected and the template editor doesn't have the same problem, would it make sense to default to dark titles that are overridden on dark layouts?

@henriqueiamarino
Copy link
Collaborator

Thanks @iamtakashi, @fushar and @supernovia. I created a fix for it. It's waiting for a review on #8682.

@iamtakashi
Copy link
Contributor

Fixed in #8682.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Customer Report Issues or PRs that were reported via Happiness. aka "Happiness Request", or "User Report". [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage [Pri] Low [Status] Auto-allocated [Type] Bug Something isn't working
Development

No branches or pull requests

6 participants