Skip to content

Restructuring auto-approvals to provide more consistency #277

Description

@gudmdharalds

Feature request

Auto-approval functionality needs restructuring so to provide more consistency. vip-go-ci needs to keep a record of approved files per pull request processed.

Background of feature request

Currently, vip-go-ci relies on file-names for auto-approvals. Hence, when a file is found to be auto-approvable, it is added to an array of approved files. However, this can be problematic, for example when multiple pull requests are being processed which make different changes to the auto-approved files: In one pull request, changes to one file are trivial, but much larger in an other one. This can cause problems, though it is rare.

Description of feature

To improve this vip-go-ci needs to keep a record of which files are approved per pull-request, and use it when approving each pull request.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions