Allow custom Javascript files for specific page #2375
+70
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
namnguyen20999
changed the title
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 51.87% | 263/507 |
| 🔴 | Branches | 21.61% | 67/310 |
| 🔴 | Functions | 14.66% | 17/116 |
| 🔴 | Lines | 53.19% | 242/455 |
Test suite run success
7 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from c5fda73
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 87.31% (-0.14% 🔻) |
3524/4036 |
| 🟡 | Branches | 69.27% (-0.06% 🔻) |
2437/3518 |
| 🟢 | Functions | 83.27% (-0.09% 🔻) |
652/783 |
| 🟢 | Lines | 87.75% (-0.16% 🔻) |
3265/3721 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / TaipyRendered.tsx |
55.17% (-9.41% 🔻) |
12.77% (-0.87% 🔻) |
37.5% (-12.5% 🔻) |
55.17% (-9.41% 🔻) |
Test suite run success
717 tests passing in 47 suites.
Report generated by 🧪jest coverage report action from 359fef6
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
FredLL-Avaiga
requested changes
Jan 2, 2025
| @@ -61,6 +62,18 @@ const setStyle = (id: string, styleString: string): void => { | |||
| } | |||
| }; | |||
|
|
|||
| // set script tag for the page | |||
| const setScript = (id: string, scriptPaths: string[]): void => { | |||
There was a problem hiding this comment.
Can we not use helmet for this ?
There was a problem hiding this comment.
I've put the script outside of the Helmet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Allowing custom javascript file for specific page from Page()
Related Tickets & Documents
#2366
Checklist
We encourage you to keep the code coverage percentage at 80% and above.