Added support for LinkBase in Avalonia resources generator #16118
Conversation
Abdesol
changed the title
maxkatz6
added
area-xaml
bug
enhancement
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
|
Please, add a test (a resource outside of the test lib with LinkBase + some test that loads it from code should be sufficient). |
- added InternalsVisibleTo of Avalonia.Build.Tasks in Avalonia.Build.Tasks.UnitTest - added test for LinkBase support
|
You can test this PR using the following package version. |
There was a problem hiding this comment.
The current implementation is wrong, see previous comments.
I don't think we should handle LinkBase in the task itself.
Let MSBuild expand the recursive globs from LinkBase into Link instead.
This is what the SDK is doing. We should probably copy this behavior.
| var path = !string.IsNullOrEmpty(link) | ||
| ? link | ||
| : relativePath; | ||
| : !string.IsNullOrEmpty(linkBase) |
There was a problem hiding this comment.
This treats LinkBase and Link the same, which isn't correct. Link is a file path whereas LinkBase is the path before the directory globs, i.e. a directory path.
| public void Does_Support_LinkBase_In_Avalonia_Resources_Generator() | ||
| { | ||
| var path = "path/to/resources"; | ||
| var expected = "/" + path; |
There was a problem hiding this comment.
The added test doesn't check the right thing: the expected path should be /path/to/resources/root.xml.
|
Closing due to inactivity |
What does the pull request do?
adds support for
LinkBasein avalonia resources generatorWhat is the current behavior?
Avalonia asset loader is not resolving for
LinkBaseWhat is the updated/expected behavior with this PR?
Using LinkBase to set resources path works
Fixed issues
Fixes #16056