Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataGrid - preserve groups collapsed state #18331

Closed
wants to merge 1 commit into from

Conversation

ltetak
Copy link
Contributor

@ltetak ltetak commented Feb 27, 2025

What does the pull request do?

DataGrid has a Grouping behavior. It has a major flaw: when the collection is Reset or just when the DataGrid control is removed and re-attached to the visual tree, it forgets the collapsed state of groups.

What is the current behavior?

Open the Control catalog DataGrid page.
On the Grouping tab collapse some groups.
Switch tabs back and forth.
Groups are expanded again.

What is the updated/expected behavior with this PR?

The state is saved and restored

How was the solution implemented (if it's not obvious)?

I tried to mimick the selection state cache on the same spot.

Checklist

Breaking changes

none

Obsoletions / Deprecations

Fixed issues

@MrJul
Copy link
Member

MrJul commented Mar 8, 2025

Thank you for your contribution.

However, the team recently decided to move DataGrid to its own repository. As part of this move, we won't accept new features for this control.

Please see this discussion for details.

However, this PR looks like a useful bug fix.
Could you please re-open the PR on the new repo?

@MrJul MrJul closed this Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants