From d44413f648467fc5298b9bd8ad0399b3c4aa33d3 Mon Sep 17 00:00:00 2001
From: "Eric Sibly [chullybun]" <eric.sibly@avanade.com>
Date: Tue, 16 Aug 2022 16:25:15 -0700
Subject: [PATCH] Rename `ToGuid` extension method. (#19)

---
 CHANGELOG.md                                                | 3 +++
 src/DbEx/DbEx.csproj                                        | 2 +-
 src/DbEx/Migration/Data/DataRow.cs                          | 2 +-
 .../Data/{ExtensionMethods.cs => DataValueConverter.cs}     | 6 +++---
 tests/DbEx.Test/SqlServerMigratorTest.cs                    | 2 +-
 5 files changed, 9 insertions(+), 6 deletions(-)
 rename src/DbEx/Migration/Data/{ExtensionMethods.cs => DataValueConverter.cs} (80%)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8f4413c..6737d72 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 Represents the **NuGet** versions.
 
+## v1.0.13
+- *Fixed:* `Int32.ToGuid` extension method changed to `DataValueConverter.IntToGuid` to be more explicit.
+
 ## v1.0.12
 - *Fixed:* `Reset` command fixed to load embedded resource file correctly.
 
diff --git a/src/DbEx/DbEx.csproj b/src/DbEx/DbEx.csproj
index db0f977..5bc306d 100644
--- a/src/DbEx/DbEx.csproj
+++ b/src/DbEx/DbEx.csproj
@@ -3,7 +3,7 @@
   <PropertyGroup>
     <TargetFramework>netstandard2.1</TargetFramework>
     <RootNamespace>DbEx</RootNamespace>
-    <Version>1.0.12</Version>
+    <Version>1.0.13</Version>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>DbEx Developers</Authors>
     <Company>Avanade</Company>
diff --git a/src/DbEx/Migration/Data/DataRow.cs b/src/DbEx/Migration/Data/DataRow.cs
index 5ae1b5a..32c2b91 100644
--- a/src/DbEx/Migration/Data/DataRow.cs
+++ b/src/DbEx/Migration/Data/DataRow.cs
@@ -113,7 +113,7 @@ public void AddColumn(DataColumn column)
 
                     case "Guid":
                         if (int.TryParse(str, out int a))
-                            column.Value = a.ToGuid();
+                            column.Value = DataValueConverter.IntToGuid(a);
                         else
                         {
                             if (Guid.TryParse(str, out Guid g))
diff --git a/src/DbEx/Migration/Data/ExtensionMethods.cs b/src/DbEx/Migration/Data/DataValueConverter.cs
similarity index 80%
rename from src/DbEx/Migration/Data/ExtensionMethods.cs
rename to src/DbEx/Migration/Data/DataValueConverter.cs
index 2a9db83..45be308 100644
--- a/src/DbEx/Migration/Data/ExtensionMethods.cs
+++ b/src/DbEx/Migration/Data/DataValueConverter.cs
@@ -6,10 +6,10 @@
 namespace DbEx.Migration.Data
 {
     /// <summary>
-    /// Provides extension methods.
+    /// Provides data value conversion.
     /// </summary>
     [DebuggerStepThrough]
-    public static class ExtensionMethods
+    public static class DataValueConverter
     {
         /// <summary>
         /// Converts an <see cref="int"/> to a <see cref="Guid"/>; e.g. '<c>1</c>' will result in '<c>00000001-0000-0000-0000-000000000000</c>'.
@@ -17,6 +17,6 @@ public static class ExtensionMethods
         /// <param name="value">The <see cref="int"/> value.</param>
         /// <returns>The corresponding <see cref="Guid"/>.</returns>
         /// <remarks>Sets the first argument with the <paramref name="value"/> and the remainder with zeroes using <see cref="Guid(int, short, short, byte[])"/>.</remarks>
-        public static Guid ToGuid(this int value) => new(value, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
+        public static Guid IntToGuid(int value) => new(value, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
     }
 }
\ No newline at end of file
diff --git a/tests/DbEx.Test/SqlServerMigratorTest.cs b/tests/DbEx.Test/SqlServerMigratorTest.cs
index 161aed2..173d4eb 100644
--- a/tests/DbEx.Test/SqlServerMigratorTest.cs
+++ b/tests/DbEx.Test/SqlServerMigratorTest.cs
@@ -92,7 +92,7 @@ public async Task A120_MigrateAll_Console()
 
             Assert.AreEqual(3, res.Count);
             var row2 = res2[0];
-            Assert.AreEqual(88.ToGuid(), row2.PersonId);
+            Assert.AreEqual(DataValueConverter.IntToGuid(88), row2.PersonId);
             Assert.AreEqual("RUNTIME", row2.Name);
             Assert.AreEqual(m.ParserArgs.UserName, row2.CreatedBy);
             Assert.AreEqual(m.ParserArgs.DateTimeNow, row2.CreatedDate);