Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return default value for FieldWithFileSize.maxFileSize #443

Merged
merged 7 commits into from
Aug 2, 2024
Merged

fix: return default value for FieldWithFileSize.maxFileSize #443

merged 7 commits into from
Aug 2, 2024

Conversation

justlevine
Copy link
Member

What

This PR fixes FieldWithFileSize.maxFileSize so it returns wp_max_file_size() (in MB) instead of an unhelpful null value.

Why

This is in-line with GF's own usage they just don't set a value on the class and instead coerce it every time it's used 🤷

Closes #440

How

Testing Instructions

Additional Info

image

Checklist:

  • This PR is tested to the best of my abilities.
  • This PR follows the WordPress Coding Standards.
  • This PR has proper inline documentation.
  • This PR has unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

@justlevine justlevine changed the base branch from fix/parent-autoloader to develop August 2, 2024 22:27
@justlevine justlevine added the safe to test ✔ This PR can be run using repository secrets label Aug 2, 2024
@justlevine justlevine merged commit dfeded3 into AxeWP:develop Aug 2, 2024
18 checks passed
@justlevine justlevine deleted the fix/maxFileSize-default branch August 2, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
safe to test ✔ This PR can be run using repository secrets
Projects
None yet
Milestone
No milestone
1 participant
@justlevine